Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sudden 404: Not Found error #245

Open
denkristoffer opened this issue Sep 19, 2018 · 13 comments
Open

Sudden 404: Not Found error #245

denkristoffer opened this issue Sep 19, 2018 · 13 comments

Comments

@denkristoffer
Copy link

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Bundlesize returns "Could not add github status. 404: Not Found"

Please mention other relevant information.
We've been using bundlesize with Circle CI for months with no issues, but during the night between the 18th and the 19th of September something has broken. We're now getting the above error. I've tried updating and replacing the token ENV var to no avail.

@siddharthkp
Copy link
Owner

siddharthkp commented Sep 19, 2018

The usual suspects are:

  • https://bundlesize-store.now.sh is down (it isn't)
  • your GitHub token expired (you replaced it)
  • your new token does not have access to add status (?)
  • bundlesize hit rate limit for GitHub (i don't think it has enough users yet :P)

GitHub error messages usually give a 404 instead of 401 in cases like this

I'd suggest checking if the token has access, and running bundlesize with --debug flag to see if spots one of the common problems

@denkristoffer
Copy link
Author

Running bundlesize with --debug gives me output ending with the following (after displaying all the chunk sizes:

 WARN  token exists: true 

 WARN  repo: "Onlaw/onlaw.dk" 

 WARN  sha: "f1c43040e6b8ad10122bfb7a22a4b44a2d10d958" 

 WARN  api enabled: true 

 WARN  fetching values: "..." 

 ERROR  Could not add github status.
        404: Not Found 

Doesn't tell me much. Any ideas?

@cihati
Copy link

cihati commented Nov 26, 2018

I have the exact same issue as @denkristoffer, any ideas @siddharthkp ? Using CircleCI.

Regarding

your new token does not have access to add status (?)

How do I check it? @siddharthkp

When I tried to generate the token, although I am being asked my GitHub credentials, I do not see another intermediate screen until https://bundlesize-store.now.sh/auth?code=XYZ site

@alexlouden

This comment has been minimized.

@siddharthkp
Copy link
Owner

Does anyone know if this means that the token doesn't have permission to update the status?

Yep, GitHub sends down a 404 if you don't have permission

@alexlouden

This comment has been minimized.

@siddharthkp

This comment has been minimized.

@landvibe
Copy link

Same here with Circle CI

@alexlouden

This comment has been minimized.

@denkristoffer
Copy link
Author

@siddharthkp I don't think this issue should be closed, missing access was never the problem in my case.

@siddharthkp
Copy link
Owner

Oops, sorry. There was another sub-thread in between.

@grumpyoldman-io
Copy link

I just fixed this on our pipeline. The BUNDLESIZE_GITHUB_TOKEN can expire. Github will reply with a 404. Follow the steps here to reset your token: https://github.com/siddharthkp/bundlesize#build-status-for-github

  1. go here: https://github.com/login/oauth/authorize?scope=repo%3Astatus&client_id=6756cb03a8d6528aca5a
  2. replace the token in your build tool with the supplied token.
  3. restart build.

@PaulKujawa
Copy link

What is the lifetime of this token? A token can not just expire without being automatically refreshed when this is supposed to be embedded into corporate CI workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants