Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh provider collection issue #634

Closed
5 tasks done
zoey-kaiser opened this issue Jan 8, 2024 · 3 comments
Closed
5 tasks done

Refresh provider collection issue #634

zoey-kaiser opened this issue Jan 8, 2024 · 3 comments
Labels
bug A bug that needs to be resolved p4 Important Issue provider-refresh An issue with the refresh provider

Comments

@zoey-kaiser
Copy link
Member

zoey-kaiser commented Jan 8, 2024

Goal

Ensure the refresh provider works as expected.

Context

In #581 we merged the refresh provider. Since then new issues have been opened, that point out issues not found during initial review. This issue aims to collect all of them to provide a better overview.

Issues

@AlejandroAkbal
Copy link

Hey, I love this library, and I'm so saddened by the fact that 90% of what I need works, but this final and important piece is missing (keeping auth after browser close/refresh)

Is there some way I can contribute to expedite this issue?

@zoey-kaiser
Copy link
Member Author

Is there some way I can contribute to expedite this issue?

Hi @AlejandroAkbal of course! I think you could help in 2 important ways:

  1. indicating which issues are blocking you most, so we can prioritize the fixes
  2. directly begin investigations or implement fixes yourself

To be completely transparent: I have recently picked up a new project, where I need to dedicate a lot of my time to. Therefore I am really having issues finding enough time to dedicate to maintaining sidebase properly, which does sadden me a lot. I have enough time to still review, merge and release external pull requests, but am really struggling to find the time to properly investigate and push fixes and new features myself.
Therefore if you manage to find a bit of time to either research for fix the issues yourself, I can get around to a review within the week. As they are also bug fixes and not completely new features, there also is not much discussion to be had about how the feature works etc.

Thank you so much for your interest in sidebase ❤️

@AlejandroAkbal
Copy link

Thank you for your honesty, no problem!

  1. My most important issue was refresh provider, which is now out, awesome!

1.1 Other issue is keeping auth state, which is (hopefully) fixed with the cookie workaround, see #626 (comment)

1.2 Another issue was that the refresh request, is send with a HTTP POST Body that cannot be changed, and my API was expecting a different structure for the Body request
It was {"refresh_token":"blabla"} instead of {"refreshToken":"blabla"}

Hoping I can look around and make a PR for this in the future

@zoey-kaiser zoey-kaiser added p4 Important Issue bug A bug that needs to be resolved provider-refresh An issue with the refresh provider labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug that needs to be resolved p4 Important Issue provider-refresh An issue with the refresh provider
Projects
None yet
Development

No branches or pull requests

3 participants