feat: support multiple Docker cluster in talosctl cluster create

Dynamically map Kubernetes and Talos API ports to an available port on
the host, so every cluster gets its own unique set of parts.

As part of the changes, refactor the provision library and interfaces,
dropping old weird interfaces replacing with (hopefully) much more
descriprive names.

Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>

cmd/talosctl/cmd/mgmt/cluster/create.go

@@ -617,46 +617,51 @@ func create(ctx context.Context, flags *pflag.FlagSet) error {
  )
  }
 
- defaultInternalLB, defaultEndpoint := provisioner.GetLoadBalancers(request.Network)
-
- if defaultInternalLB == "" {
- // provisioner doesn't provide internal LB, so use first controlplane node
- defaultInternalLB = ips[0][0].String()
- }
+ externalKubernetesEndpoint := provisioner.GetExternalKubernetesControlPlaneEndpoint(request.Network, controlPlanePort)
 
  if useVIP {
- defaultInternalLB = vip.String()
+ externalKubernetesEndpoint = "https://" + nethelpers.JoinHostPort(vip.String(), controlPlanePort)
  }
 
- var endpointList []string
+ provisionOptions = append(provisionOptions, provision.WithKubernetesEndpoint(externalKubernetesEndpoint))
 
- switch {
- case defaultEndpoint != "":
- if forceEndpoint == "" {
- forceEndpoint = defaultEndpoint
- }
+ endpointList := provisioner.GetTalosAPIEndpoints(request.Network)
 
-  fallthrough
+ switch {
  case forceEndpoint != "":
- endpointList = []string{forceEndpoint}
  // using non-default endpoints, provision additional cert SANs and fix endpoint list
- provisionOptions = append(provisionOptions, provision.WithEndpoint(forceEndpoint))
+ endpointList = []string{forceEndpoint}
  genOptions = append(genOptions, generate.WithAdditionalSubjectAltNames(endpointList))
  case forceInitNodeAsEndpoint:
  endpointList = []string{ips[0][0].String()}
- default:
+ case len(endpointList) > 0:
+ for _, endpointHostPort := range endpointList {
+ endpointHost, _, err := net.SplitHostPort(endpointHostPort)
+ if err != nil {
+ endpointHost = endpointHostPort
+ }
+
+ genOptions = append(genOptions, generate.WithAdditionalSubjectAltNames([]string{endpointHost}))
+ }
+ case endpointList == nil:
  // use control plane nodes as endpoints, client-side load-balancing
  for i := range controlplanes {
  endpointList = append(endpointList, ips[0][i].String())
  }
  }
 
+ inClusterEndpoint := provisioner.GetInClusterKubernetesControlPlaneEndpoint(request.Network, controlPlanePort)
+
+ if useVIP {
+ inClusterEndpoint = "https://" + nethelpers.JoinHostPort(vip.String(), controlPlanePort)
+ }
+
  genOptions = append(genOptions, generate.WithEndpointList(endpointList))
  configBundleOpts = append(configBundleOpts,
  bundle.WithInputOptions(
  &bundle.InputOptions{
  ClusterName: clusterName,
- Endpoint: fmt.Sprintf("https://%s", nethelpers.JoinHostPort(defaultInternalLB, controlPlanePort)),
+ Endpoint: inClusterEndpoint,
  KubeVersion: strings.TrimPrefix(kubernetesVersion, "v"),
  GenOptions: genOptions,
  }),
@@ -797,10 +802,6 @@ func create(ctx context.Context, flags *pflag.FlagSet) error {
  UUID: pointer.To(nodeUUID),
  }
 
- if i == 0 {
- nodeReq.Ports = []string{"50000:50000/tcp", fmt.Sprintf("%d:%d/tcp", controlPlanePort, controlPlanePort)}
- }
-
  if withInitNode && i == 0 {
  cfg = configBundle.Init()
  nodeReq.Type = machine.TypeInit
@@ -981,7 +982,7 @@ func mergeKubeconfig(ctx context.Context, clusterAccess *access.Adapter) error {
 
  if clusterAccess.ForceEndpoint != "" {
  for name := range kubeConfig.Clusters {
- kubeConfig.Clusters[name].Server = fmt.Sprintf("https://%s", nethelpers.JoinHostPort(clusterAccess.ForceEndpoint, controlPlanePort))
+ kubeConfig.Clusters[name].Server = clusterAccess.ForceEndpoint
  }
  }
 
@@ -1169,7 +1170,7 @@ func init() {
  createCmd.Flags().BoolVar(&badRTC, "bad-rtc", false, "launch VM with bad RTC state (QEMU only)")
  createCmd.Flags().StringVar(&extraBootKernelArgs, "extra-boot-kernel-args", "", "add extra kernel args to the initial boot from vmlinuz and initramfs (QEMU only)")
  createCmd.Flags().BoolVar(&dockerDisableIPv6, "docker-disable-ipv6", false, "skip enabling IPv6 in containers (Docker only)")
- createCmd.Flags().IntVar(&controlPlanePort, controlPlanePortFlag, constants.DefaultControlPlanePort, "control plane port (load balancer and local API port)")
+ createCmd.Flags().IntVar(&controlPlanePort, controlPlanePortFlag, constants.DefaultControlPlanePort, "control plane port (load balancer and local API port, QEMU only)")
  createCmd.Flags().IntVar(&kubePrismPort, kubePrismFlag, constants.DefaultKubePrismPort, "KubePrism port (set to 0 to disable)")
  createCmd.Flags().BoolVar(&dhcpSkipHostname, "disable-dhcp-hostname", false, "skip announcing hostname via DHCP (QEMU only)")
  createCmd.Flags().BoolVar(&skipBootPhaseFinishedCheck, "skip-boot-phase-finished-check", false, "skip waiting for node to finish boot phase")

cmd/talosctl/cmd/mgmt/cluster/show.go

@@ -63,6 +63,7 @@ func showCluster(cluster provision.Cluster) error {
 
  fmt.Fprintf(w, "NETWORK GATEWAY\t%s\n", strings.Join(gateways, ","))
  fmt.Fprintf(w, "NETWORK MTU\t%d\n", cluster.Info().Network.MTU)
+ fmt.Fprintf(w, "KUBERNETES ENDPOINT\t%s\n", cluster.Info().KubernetesEndpoint)
 
  if err := w.Flush(); err != nil {
  return err

go.mod

@@ -60,7 +60,7 @@ require (
  github.com/containernetworking/plugins v1.4.1
  github.com/coredns/coredns v1.11.2
  github.com/coreos/go-iptables v0.7.0
- github.com/cosi-project/runtime v0.4.0
+ github.com/cosi-project/runtime v0.4.1
  github.com/distribution/reference v0.6.0
  github.com/docker/docker v26.0.0+incompatible
  github.com/docker/go-connections v0.5.0
@@ -169,7 +169,7 @@ require (
  golang.org/x/text v0.14.0
  golang.org/x/time v0.5.0
  golang.zx2c4.com/wireguard/wgctrl v0.0.0-20230429144221-925a1e7659e6
- google.golang.org/grpc v1.63.0
+ google.golang.org/grpc v1.62.1
  google.golang.org/protobuf v1.33.0
  gopkg.in/yaml.v3 v3.0.1
  k8s.io/klog/v2 v2.120.1
@@ -301,7 +301,7 @@ require (
  github.com/opentracing/opentracing-go v1.2.0 // indirect
  github.com/pelletier/go-toml/v2 v2.0.6 // indirect
  github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
- github.com/pierrec/lz4/v4 v4.1.14 // indirect
+ github.com/pierrec/lz4/v4 v4.1.15 // indirect
  github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect
  github.com/pkg/errors v0.9.1 // indirect
  github.com/planetscale/vtprotobuf v0.6.0 // indirect
@@ -317,7 +317,7 @@ require (
  github.com/siderolabs/protoenc v0.2.1 // indirect
  github.com/siderolabs/tcpproxy v0.1.0 // indirect
  github.com/sirupsen/logrus v1.9.3 // indirect
- github.com/spf13/afero v1.9.3 // indirect
+ github.com/spf13/afero v1.10.0 // indirect
  github.com/spf13/cast v1.5.0 // indirect
  github.com/spf13/jwalterweatherman v1.1.0 // indirect
  github.com/spf13/viper v1.14.0 // indirect
@@ -333,7 +333,7 @@ require (
  go.etcd.io/etcd/raft/v3 v3.5.13 // indirect
  go.etcd.io/etcd/server/v3 v3.5.13 // indirect
  go.opencensus.io v0.24.0 // indirect
- go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 // indirect
+ go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1 // indirect
  go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0 // indirect
  go.opentelemetry.io/otel v1.22.0 // indirect
  go.opentelemetry.io/otel/metric v1.22.0 // indirect

go.sum

@@ -189,8 +189,8 @@ github.com/coreos/go-semver v0.3.1 h1:yi21YpKnrx1gt5R+la8n5WgS0kCrsPp33dmEyHReZr
 github.com/coreos/go-semver v0.3.1/go.mod h1:irMmmIw/7yzSRPWryHsK7EYSg09caPQL03VsM8rvUec=
 github.com/coreos/go-systemd/v22 v22.5.0 h1:RrqgGjYQKalulkV8NGVIfkXQf6YYmOyiJKk8iXXhfZs=
 github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
-github.com/cosi-project/runtime v0.4.0 h1:sK4UYOvafWzb0/doZf3wl/Pob2lZD3DgZTo7tzGW/Lw=
-github.com/cosi-project/runtime v0.4.0/go.mod h1:DOeuuUaUE1c5c4biqkDZWTfCJl6BdYtxuOzvRVOoRV8=
+github.com/cosi-project/runtime v0.4.1 h1:9lJWw5cl3Lz1qP32bl2vxAsJs6LM8KdUGLCc9t/EGqw=
+github.com/cosi-project/runtime v0.4.1/go.mod h1:eXVAHf9QzzSVblLUtHHPFOZ7JBuz+GypHbao1vw+SdQ=
 github.com/cpuguy83/go-md2man/v2 v2.0.2/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
 github.com/cpuguy83/go-md2man/v2 v2.0.3 h1:qMCsGGgs+MAzDFyp9LpAe1Lqy/fY/qCovCm0qnXZOBM=
 github.com/cpuguy83/go-md2man/v2 v2.0.3/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
@@ -601,8 +601,8 @@ github.com/pelletier/go-toml/v2 v2.0.6 h1:nrzqCb7j9cDFj2coyLNLaZuJTLjWjlaz6nvTvI
 github.com/pelletier/go-toml/v2 v2.0.6/go.mod h1:eumQOmlWiOPt5WriQQqoM5y18pDHwha2N+QD+EUNTek=
 github.com/peterbourgon/diskv v2.0.1+incompatible h1:UBdAOUP5p4RWqPBg048CAvpKN+vxiaj6gdUUzhl4XmI=
 github.com/peterbourgon/diskv v2.0.1+incompatible/go.mod h1:uqqh8zWWbv1HBMNONnaR/tNboyR3/BZd58JJSHlUSCU=
-github.com/pierrec/lz4/v4 v4.1.14 h1:+fL8AQEZtz/ijeNnpduH0bROTu0O3NZAlPjQxGn8LwE=
-github.com/pierrec/lz4/v4 v4.1.14/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
+github.com/pierrec/lz4/v4 v4.1.15 h1:MO0/ucJhngq7299dKLwIMtgTfbkoSPF6AoMYDd8Q4q0=
+github.com/pierrec/lz4/v4 v4.1.15/go.mod h1:gZWDp/Ze/IJXGXf23ltt2EXimqmTUXEy0GFuRQyBid4=
 github.com/pin/tftp/v3 v3.1.0 h1:rQaxd4pGwcAJnpId8zC+O2NX3B2/NscjDZQaqEjuE7c=
 github.com/pin/tftp/v3 v3.1.0/go.mod h1:xwQaN4viYL019tM4i8iecm++5cGxSqen6AJEOEyEI0w=
 github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c h1:+mdjkGKdHQG3305AYmdv1U2eRNDiU2ErMBj1gwrq8eQ=
@@ -723,8 +723,8 @@ github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ
 github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
 github.com/smira/kobject v0.0.0-20240304111826-49c8d4613389 h1:f/5NRv5IGZxbjBhc5MnlbNmyuXBPxvekhBAUzyKWyLY=
 github.com/smira/kobject v0.0.0-20240304111826-49c8d4613389/go.mod h1:+SexPO1ZvdbbWUdUnyXEWv3+4NwHZjKhxOmQqHY4Pqc=
-github.com/spf13/afero v1.9.3 h1:41FoI0fD7OR7mGcKE/aOiLkGreyf8ifIOQmJANWogMk=
-github.com/spf13/afero v1.9.3/go.mod h1:iUV7ddyEEZPO5gA3zD4fJt6iStLlL+Lg4m2cihcDf8Y=
+github.com/spf13/afero v1.10.0 h1:EaGW2JJh15aKOejeuJ+wpFSHnbd7GE6Wvp3TsNhb6LY=
+github.com/spf13/afero v1.10.0/go.mod h1:UBogFpq8E9Hx+xc5CNTTEpTnuHVmXDwZcZcE1eb/UhQ=
 github.com/spf13/cast v1.5.0 h1:rj3WzYc11XZaIZMPKmwP96zkFEnnAmV8s6XbB2aY32w=
 github.com/spf13/cast v1.5.0/go.mod h1:SpXXQ5YoyJw6s3/6cMTQuxvgRl3PCJiyaX9p6b155UU=
 github.com/spf13/cobra v1.8.0 h1:7aJaZx1B85qltLMc546zn58BxxfZdR/W22ej9CFoEf0=
@@ -813,8 +813,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
 go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
 go.opencensus.io v0.24.0 h1:y73uSU6J157QMP2kn2r30vwW1A2W2WFwSCGnAVxeaD0=
 go.opencensus.io v0.24.0/go.mod h1:vNK8G9p7aAivkbmorf4v+7Hgx+Zs0yY+0fOtgBfjQKo=
-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0 h1:PzIubN4/sjByhDRHLviCjJuweBXWFZWhghjg7cS28+M=
-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.0/go.mod h1:Ct6zzQEuGK3WpJs2n4dn+wfJYzd/+hNnxMRTWjGn30M=
+go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1 h1:SpGay3w+nEwMpfVnbqOLH5gY52/foP8RE8UzTZ1pdSE=
+go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1/go.mod h1:4UoMYEZOC0yN/sPGH76KPkkU7zgiEWYWL9vwmbnTJPE=
 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0 h1:sv9kVfal0MK0wBMCOGr+HeJm9v803BkJxGrk2au7j08=
 go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0/go.mod h1:SK2UL73Zy1quvRPonmOmRDiWk1KBV3LyIeeIxcEApWw=
 go.opentelemetry.io/otel v1.22.0 h1:xS7Ku+7yTFvDfDraDIJVpw7XPyuHlB9MCiqqX5mcJ6Y=
@@ -849,7 +849,7 @@ golang.org/x/crypto v0.0.0-20200420201142-3c4aac89819a/go.mod h1:LzIPMQfyMNhhGPh
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
 golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
-golang.org/x/crypto v0.0.0-20211108221036-ceb1ce70b4fa/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
+golang.org/x/crypto v0.0.0-20220722155217-630584e8d5aa/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
 golang.org/x/crypto v0.3.1-0.20221117191849-2c476679df9a/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4=
 golang.org/x/crypto v0.7.0/go.mod h1:pYwdfH91IfpZVANVyUOhSIPZaFoJGxTFbZhFTx+dXZU=
 golang.org/x/crypto v0.13.0/go.mod h1:y6Z2r+Rw4iayiXXAIxJIDAJ1zMW4yaTpebo8fPOliYc=
@@ -933,6 +933,7 @@ golang.org/x/net v0.0.0-20201224014010-6772e930b67b/go.mod h1:m0MpNAwzfU5UDzcl9v
 golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
 golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4/go.mod h1:p54w0d4576C0XHj96bSt6lcn1PtDYWL6XObtHCRCNQM=
 golang.org/x/net v0.0.0-20210428140749-89ef3d95e781/go.mod h1:OJAsFXCWl8Ukc7SiCT/9KSuxbyM7479/AVlXFRxuMCk=
+golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y=
 golang.org/x/net v0.0.0-20220722155237-a158d28d115b/go.mod h1:XRhObCWvk6IyKnWLug+ECip1KBveYUHfp+8e9klMJ9c=
 golang.org/x/net v0.2.0/go.mod h1:KqCZLdyyvdV855qA2rE3GC2aiw5xGR5TEjj8smXukLY=
 golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
@@ -1215,8 +1216,8 @@ google.golang.org/grpc v1.31.1/go.mod h1:N36X2cJ7JwdamYAgDz+s+rVMFjt3numwzf/HckM
 google.golang.org/grpc v1.33.2/go.mod h1:JMHMWHQWaTccqQQlmk3MJZS+GWXOdAesneDmEnv2fbc=
 google.golang.org/grpc v1.34.0/go.mod h1:WotjhfgOW/POjDeRt8vscBtXq+2VjORFy659qA51WJ8=
 google.golang.org/grpc v1.35.0/go.mod h1:qjiiYl8FncCW8feJPdyg3v6XW24KsRHe+dy9BAGRRjU=
-google.golang.org/grpc v1.63.0 h1:WjKe+dnvABXyPJMD7KDNLxtoGk5tgk+YFWN6cBWjZE8=
-google.golang.org/grpc v1.63.0/go.mod h1:WAX/8DgncnokcFUldAxq7GeB5DXHDbMF+lLvDomNkRA=
+google.golang.org/grpc v1.62.1 h1:B4n+nfKzOICUXMgyrNd19h/I9oH0L1pizfk1d4zSgTk=
+google.golang.org/grpc v1.62.1/go.mod h1:IWTG0VlJLCh1SkC58F7np9ka9mx/WNkjl4PGJaiq+QE=
 google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
 google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
 google.golang.org/protobuf v0.0.0-20200228230310-ab0ca4ff8a60/go.mod h1:cfTl7dwQJ+fmap5saPgwCLgHXTUD7jkjRqWcaiX5VyM=

hack/test/e2e-docker.sh

@@ -21,8 +21,6 @@ function create_cluster {
  --memory=2048 \
  --cpus=2.0 \
  --with-init-node=false \
- --docker-host-ip=127.0.0.1 \
- --endpoint=127.0.0.1 \
  ${REGISTRY_MIRROR_FLAGS} \
  --crashdump
 

hack/test/e2e.sh

@@ -171,7 +171,7 @@ function run_talos_integration_test_docker {
  ;;
  esac
 
- "${INTEGRATION_TEST}" -test.v -talos.talosctlpath "${TALOSCTL}" -talos.kubectlpath "${KUBECTL}" -talos.k8sendpoint 127.0.0.1:6443 -talos.provisioner "${PROVISIONER}" -talos.name "${CLUSTER_NAME}" -talos.image "${REGISTRY}/siderolabs/talos" "${EXTRA_TEST_ARGS[@]}" "${TEST_RUN[@]}" "${TEST_SHORT[@]}"
+ "${INTEGRATION_TEST}" -test.v -talos.talosctlpath "${TALOSCTL}" -talos.kubectlpath "${KUBECTL}" -talos.provisioner "${PROVISIONER}" -talos.name "${CLUSTER_NAME}" -talos.image "${REGISTRY}/siderolabs/talos" "${EXTRA_TEST_ARGS[@]}" "${TEST_RUN[@]}" "${TEST_SHORT[@]}"
 }
 
 function run_kubernetes_conformance_test {

internal/app/apid/main.go

@@ -73,7 +73,7 @@ func apidMain() error {
 
  startup.LimitMaxProcs(constants.ApidMaxProcs)
 
- runtimeConn, err := grpc.NewClient("unix://"+constants.APIRuntimeSocketPath, grpc.WithTransportCredentials(insecure.NewCredentials()))
+ runtimeConn, err := grpc.Dial("unix://"+constants.APIRuntimeSocketPath, grpc.WithTransportCredentials(insecure.NewCredentials()))
  if err != nil {
  return fmt.Errorf("failed to dial runtime connection: %w", err)
  }

internal/app/apid/pkg/backend/apid.go

@@ -95,7 +95,7 @@ func (a *APID) GetConnection(ctx context.Context, fullMethodName string) (contex
  backoffConfig := backoff.DefaultConfig
  backoffConfig.MaxDelay = 15 * time.Second
 
- a.conn, err = grpc.NewClient(
+ a.conn, err = grpc.Dial(
  fmt.Sprintf("%s:%d", net.FormatAddress(a.target), constants.ApidPort),
  grpc.WithInitialWindowSize(65535*32),
  grpc.WithInitialConnWindowSize(65535*16),

internal/app/machined/internal/server/v1alpha1/v1alpha1_time_test.go

@@ -68,7 +68,7 @@ func (suite *TimedSuite) TestTime() {
  //nolint:errcheck
  go server.Serve(listener)
 
- conn, err := grpc.NewClient(
+ conn, err := grpc.Dial(
  fmt.Sprintf("%s://%s", "unix", listener.Addr().String()),
  grpc.WithTransportCredentials(insecure.NewCredentials()),
  grpc.WithContextDialer(dialer.DialUnix()),
@@ -102,7 +102,7 @@ func (suite *TimedSuite) TestTimeCheck() {
  //nolint:errcheck
  go server.Serve(listener)
 
- conn, err := grpc.NewClient(
+ conn, err := grpc.Dial(
  fmt.Sprintf("%s://%s", "unix", listener.Addr().String()),
  grpc.WithTransportCredentials(insecure.NewCredentials()),
  grpc.WithContextDialer(dialer.DialUnix()),

internal/app/machined/pkg/controllers/runtime/events_sink.go

@@ -161,7 +161,7 @@ func (ctrl *EventsSinkController) Run(ctx context.Context, r controller.Runtime,
  // establish connection
  logger.Debug("establishing connection to event sink", zap.String("endpoint", cfg.TypedSpec().Endpoint))
 
- conn, err = grpc.NewClient(
+ conn, err = grpc.Dial(
  cfg.TypedSpec().Endpoint,
  grpc.WithTransportCredentials(insecure.NewCredentials()),
  grpc.WithSharedWriteBuffer(true),

internal/app/machined/pkg/controllers/siderolink/manager.go

@@ -314,7 +314,7 @@ func (ctrl *ManagerController) provision(ctx context.Context, r controller.Runti
  nodeUUID := sysInfo.TypedSpec().UUID
 
  provision := func() (*pb.ProvisionResponse, error) {
- conn, connErr := grpc.NewClient(
+ conn, connErr := grpc.Dial(
  cfg.TypedSpec().Host,
  withTransportCredentials(cfg.TypedSpec().Insecure),
  grpc.WithSharedWriteBuffer(true),

internal/app/trustd/main.go

@@ -67,7 +67,7 @@ func trustdMain() error {
 
  var err error
 
- runtimeConn, err := grpc.NewClient(
+ runtimeConn, err := grpc.Dial(
  "unix://"+constants.TrustdRuntimeSocketPath,
  grpc.WithTransportCredentials(insecure.NewCredentials()),
  grpc.WithSharedWriteBuffer(true),