Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all required kubelet mount points exists #397

Closed
andrewrynhard opened this issue Feb 20, 2019 · 1 comment · Fixed by #461
Closed

Ensure all required kubelet mount points exists #397

andrewrynhard opened this issue Feb 20, 2019 · 1 comment · Fixed by #461

Comments

@andrewrynhard
Copy link
Member

It might be good to double check how we run the kubelet in Talos against this: kubernetes/kubernetes#74148 (comment)

@bradbeam
Copy link
Contributor

Comparing against the list there's a few deltas with regards to what is being shared with the container --

  • instances of additional binaries and libraries being mounted up ( mkfs.xfs / iscsiadm )
  • host ssl certs
  • cni config + binaries

I could see a case for sharing host ssl certs with hyperkube, but the additional binaries seem redundant ( hyperkube already contains mkfs.xfs/ext{2,3,4} ) along with the most recent cni release at the time the hyperkube version was released ( so perhaps we can trim that out of our rootfs ( https://github.com/autonomy/talos/blob/master/Dockerfile#L171-L174 ).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants