Fix node 18 (based on #711)

[nofarham]

Based on @vicary suggestion

[wellwelwel]

Thanks, @nofarham 🙋🏻‍♂️

Looking your comment and the #711 (comment), do you think there is a way to reproduce this error to add a test on it?

[nofarham]

@wellwelwel Running the following code should trigger the error

const data = // get the data with query.stream
for await (const row of data) {
   console.log(row)
}

[wellwelwel]

Perhaps we could include this test case here:

node-mysql2/test/integration/connection/test-stream.js

Lines 48 to 63 in e6a9306

	connection.execute('SELECT * FROM announcements', (err, _rows) => {
	rows = _rows;
	const s1 = connection.query('SELECT * FROM announcements').stream();
	s1.on('data', row => {
	rows1.push(row);
	});
	s1.on('end', () => {
	const s2 = connection.execute('SELECT * FROM announcements').stream();
	s2.on('data', row => {
	rows2.push(row);
	});
	s2.on('end', () => {
	connection.end();
	});
	});
	});

[nofarham]

@wellwelwel can you add this code after the "connection.execute"?

    const s3 = connection.query('SELECT * FROM announcements').stream();
    for await (const row of s3) {
      rows3.push(row);
    }

process.on('exit', () => {
  assert.deepEqual(rows.length, 2);
...
  assert.deepEqual(rows, rows3);
});

[wellwelwel]

@nofarham, testing it locally, everything works great 🚀

• with your fix:
  • exited with code 0
• without your fix:
  • Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close

---

Just an observation: this error occurs from Node 18, so it also occurs in Node 19, 20 and 21.

---

Testing:

+ const rows3 = [];

- connection.execute('SELECT * FROM announcements', (err, _rows) => {
+ connection.execute('SELECT * FROM announcements', async (err, _rows) => {

+ const s3 = connection.query('SELECT * FROM announcements').stream();
+ for await (const row of s3) {
+   rows3.push(row);
+ }

+ assert.deepEqual(rows, rows3);

[wellwelwel]

can you add this code after the "connection.execute"?

If I commit something to your branch, it will be included in your PR.
@nofarham, wouldn't you prefer to add it? However, yes, I can do that 🙋🏻‍♂️

[nofarham]

@wellwelwel Thank you I have added the tests

[wellwelwel]

Thank you I have added the tests

@nofarham, you're welcome 🙋🏻‍♂️

All the main tests were passed, just fix an indentation conflict with the lint and we can merge it 🚀

You can check it locally by running npm run lint.

[wellwelwel]

Thanks again, @nofarham 🚀

[nofarham]

@wellwelwel, when is the new version will be released?

[wellwelwel]

when is the new version will be released?

@nofarham, it's here (3.8.0) 🙋🏻‍♂️