-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): improve the contribution guidelines #2552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2552 +/- ##
==========================================
- Coverage 91.20% 90.31% -0.89%
==========================================
Files 69 71 +2
Lines 15547 15700 +153
Branches 1331 1332 +1
==========================================
Hits 14179 14179
- Misses 1368 1521 +153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sidorares, treating this as a I thought that by changing the PR title, it would automatically update the commit message when it was squashed, but this only applies to multiple commits. |
Since it changes the Contributing.md, I'll keep it for you 🙋🏻♂️ |
somehow missed it, lgtm |
This PR improves the Contributing Guidelines based in some recent events.
c8
all
option.Contributing Guidelines
npm run coverage-test
to Running Tests section.Codecov
I've changed the target from 90% to 89%, because after specifying the exact paths and ensuring that all files are checked, the current score (90.31%) is too close to the limit.