-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): reads should emit the dataset number for each dataset #2628
Conversation
…streaming-interface-should-provide-dataset-index
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2628 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 71 71
Lines 15727 15727
Branches 1339 1339
=======================================
Hits 14206 14206
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just confirming from mysqljs side before merging:
|
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mysql2](https://sidorares.github.io/node-mysql2/docs) ([source](https://github.com/sidorares/node-mysql2)) | dependencies | minor | [`3.9.8` -> `3.10.0`](https://renovatebot.com/diffs/npm/mysql2/3.9.8/3.10.0) | --- ### Release Notes <details> <summary>sidorares/node-mysql2 (mysql2)</summary> ### [`v3.10.0`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#3100-2024-05-30) [Compare Source](sidorares/node-mysql2@v3.9.9...v3.10.0) ##### Features - add jsonStrings option ([#​2642](sidorares/node-mysql2#2642)) ([9820fe5](sidorares/node-mysql2@9820fe5)) ##### Bug Fixes - **stream:** reads should emit the dataset number for each dataset ([#​2628](sidorares/node-mysql2#2628)) ([4dab4ca](sidorares/node-mysql2@4dab4ca)) ### [`v3.9.9`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#399-2024-05-29) [Compare Source](sidorares/node-mysql2@v3.9.8...v3.9.9) ##### Bug Fixes - **connection config:** remove keepAliveInitialDelay default value ([#​2712](sidorares/node-mysql2#2712)) ([688ebab](sidorares/node-mysql2@688ebab)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/Droplet/pulls/314 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
Testing locally: