-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setMaxParserCache throws TypeError #2757
fix: setMaxParserCache throws TypeError #2757
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2757 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 71 71
Lines 15731 15731
Branches 1345 1345
=======================================
Hits 14210 14210
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @constb, thanks 🚀 About the This PR allows to continue showing the alerts, but without blocking the CI due to files individually: |
replace parser cache with a new one on setMaxParserCache to avoid TypeError, because
max
is now read-only on LRU caches and cannot be altered.