-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/dropdown): breadcrumb dropdown overflow #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a visual regression testcase
@danielleroux The fix is done and the visual regression test is done. Its not passing the build only here, on my machine works perfect. I think its because it is expecting to have a snapshot from a linux, you should just run the tests, and commit the snapshot. |
Did you executed the test inside Docker? I will update the snapshots. |
@goncalosard I checked the PR i will refactor the changes regarding the breadcrumb a little bit, because it is more sustainable to adapt the max-height within the dropdown it self |
@nuke-ellington @goncalosard Can you please review the changes, i have made regarding dropdown? I will also resolve the merge conflicts |
Summary
Breadcrumb dropdown now has the max-height for 5 items, after that it will have a scroll for the overflow.
Fixes #77
How did you test this change?
Tested locally