Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/form-validation): form-validation invalid correction #383

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #273

What is the new behavior?

Inputs no longer starts already invalid.
Only after submit, it takes the invalid css styles.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added the type: bug Something isn't working label Feb 15, 2023
@goncalosard goncalosard linked an issue Feb 15, 2023 that may be closed by this pull request
1 task
@goncalosard goncalosard changed the title fix(core): form-validation invalid correction fix(core/form-validation): form-validation invalid correction Feb 15, 2023
@danielleroux danielleroux added semvers: patch and removed type: bug Something isn't working labels Feb 16, 2023
@danielleroux danielleroux added this to the 1.4.0 milestone Feb 16, 2023
@danielleroux danielleroux merged commit e9e7fce into main Feb 16, 2023
@danielleroux danielleroux deleted the fix/form-validation branch February 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input validation support for .was-validated
2 participants