Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/toggle): component rework #568

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

[IX-79]

What is the new behavior?

  • Updated the style according to Figma
  • Updated the VRT
  • Added Checked and Indeterminate examples to the documentation.
  • Fixed bug with the width, now width is fit-content and no longer extends to the max size of the window.

Does this introduce a breaking change?

  • Yes
  • No

@goncalosard goncalosard added this to the 1.7.0 milestone May 31, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 17daf4b into main Jul 27, 2023
@danielleroux danielleroux deleted the feat/toggle-switch-rework branch July 27, 2023 13:11
@danielleroux danielleroux modified the milestones: 1.7.0, 2.0.0 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants