Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lable for "ix-menu-about" inside menu #595

Closed
marvingreeven opened this issue Jun 23, 2023 · 1 comment · Fixed by #592
Closed

Add lable for "ix-menu-about" inside menu #595

marvingreeven opened this issue Jun 23, 2023 · 1 comment · Fixed by #592
Labels
type: bug Something isn't working type: enhancement New feature or request
Milestone

Comments

@marvingreeven
Copy link

marvingreeven commented Jun 23, 2023

Suggestion / feature request

Right now the property "label" at the "ix-menu-about" item just sets the label at the top.
The label inside the menu is not affected.

tempsnip
image

@marvingreeven marvingreeven added triage We discuss this topic in our internal weekly type: enhancement New feature or request labels Jun 23, 2023
@danielleroux danielleroux added type: bug Something isn't working and removed triage We discuss this topic in our internal weekly labels Jun 27, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jun 27, 2023
@danielleroux danielleroux linked a pull request Jun 27, 2023 that will close this issue
14 tasks
@danielleroux
Copy link
Collaborator

@marvingreeven Currently you have to provide the about item label inside the ix-menu

<ix-menu i18nLegal="{{ '~086e3 About and Legal Information' | translate }}">
        <ix-menu-about>
          <ix-menu-about-item label="Tab 1">Content 1</ix-menu-about-item>
          <ix-menu-about-item label="Tab 2">Content 2</ix-menu-about-item>
        </ix-menu-about>
</ix-menu>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants