Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/slider): add slider component #723

Merged
merged 24 commits into from
Sep 13, 2023
Merged

feat(core/slider): add slider component #723

merged 24 commits into from
Sep 13, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Add slider component

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added this to the 2.0.0 milestone Aug 25, 2023
@danielleroux danielleroux changed the title Feat/slider feat(core/slider): add slider component Aug 25, 2023
@jg0815
Copy link
Contributor

jg0815 commented Aug 30, 2023

A11Y Review

The slider component has the following accessibility issues:

Image 1: Operating sequence with insufficient tooltip placement

iX-Slider - Insufficient tooltip placement (Step 0 - 4)

Image 2: Non-dismissable tooltip overlay (I)

iX-Slider - Non-dismissable tooltip overlay (Value 0)

Image 3: Non-dismissable tooltip overlay (II)

iX-Slider - Non-dismissable tooltip overlay (Value 33)

Image 4: Non-dismissable tooltip overlay (III)

iX-Slider - Non-dismissable tooltip overlay (Value 100)

packages/core/src/components/slider/slider.tsx Outdated Show resolved Hide resolved
packages/core/src/components/slider/slider.tsx Outdated Show resolved Hide resolved
packages/core/src/components/slider/slider.tsx Outdated Show resolved Hide resolved
packages/core/src/components/slider/slider.tsx Outdated Show resolved Hide resolved
nuke-ellington
nuke-ellington previously approved these changes Sep 4, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux marked this pull request as ready for review September 5, 2023 07:05
nuke-ellington
nuke-ellington previously approved these changes Sep 5, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nuke-ellington
nuke-ellington previously approved these changes Sep 5, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@danielleroux danielleroux merged commit 6a7f3cb into main Sep 13, 2023
@danielleroux danielleroux deleted the feat/slider branch September 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants