-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/slider): add slider component #723
Conversation
A11Y ReviewThe slider component has the following accessibility issues:
Image 1: Operating sequence with insufficient tooltip placement Image 2: Non-dismissable tooltip overlay (I) Image 3: Non-dismissable tooltip overlay (II) Image 4: Non-dismissable tooltip overlay (III) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?