Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IxSelect] Support for Angular Forms #736

Closed
Tiagogv opened this issue Sep 4, 2023 · 1 comment · Fixed by #738
Closed

[IxSelect] Support for Angular Forms #736

Tiagogv opened this issue Sep 4, 2023 · 1 comment · Fixed by #738
Labels
type: enhancement New feature or request

Comments

@Tiagogv
Copy link
Contributor

Tiagogv commented Sep 4, 2023

Suggestion / feature request

The IxSelectComponent on Angular should work natively with either with Template Driven or Reactive Forms.

As an example for Template Driven form:

<ix-select [(ngModel)]="value" name="select-control">
  <ix-select-option value="1" label="Option 1"/>
  <ix-select-option value="2" label="Option 2"/>
</ix-select>

and Reactive form:

<ix-select [formControl]="form">
  <ix-select-option value="1" label="Option 1"/>
  <ix-select-option value="2" label="Option 2"/>
</ix-select>

For this an implementation of a directive using the ControlValueAccessor interface should be created.
Happy to create PR for this.

@Tiagogv Tiagogv added triage We discuss this topic in our internal weekly type: enhancement New feature or request labels Sep 4, 2023
@danielleroux danielleroux removed the triage We discuss this topic in our internal weekly label Sep 4, 2023
@danielleroux
Copy link
Collaborator

danielleroux commented Sep 4, 2023

Sounds good. But keep in mind we are using the stencil-out-targets, this provides the posibility to generate valueAccessors out of the webcomponents https://stenciljs.com/docs/angular#valueaccessorconfigs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants