Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/datepicker/timepicker/datetimepicker): refactor #737

Merged
merged 132 commits into from
Nov 13, 2023
Merged

feat(core/datepicker/timepicker/datetimepicker): refactor #737

merged 132 commits into from
Nov 13, 2023

Conversation

lzeiml
Copy link
Contributor

@lzeiml lzeiml commented Sep 4, 2023 •
edited by matthiashader
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

#593
#698
#703
#702
#697

What is the new behavior?

  • Refactor ix-date-picker
  • Use Dayjs instead of luxon
  • Remove deprecated properties
  • Start the week based on the locale or on a new property weekStartIndex
  • Disable years/months based on the min/max-date properties
  • Fix infinite scroll
  • Refactor time-picker

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

lzeiml added 25 commits August 29, 2023 09:13
@lzeiml
refactor: dayjs, fix: infinite scroll
85be804
@lzeiml
feat: configure starting day of week
de564b6
@lzeiml
refactor: calculateCalender simplified, remove luxon
1e56e1c
@lzeiml
refactor: day styling
4dac621
@lzeiml
refactor: min/max-date
2561b32
@lzeiml
docs: date-picker breaking change
4275aee
@lzeiml
refactor: year list
59d4071
@lzeiml
fix: calculateCalendar, refactor: more dayjs
6ecffae
@lzeiml
refactor: add CalendarWeek interface
b6909a9
@lzeiml
docs: add breaking change
04909a3
@lzeiml
refactor: day selection
8fd26b4
@lzeiml
refactor: don't mutate properties from/to, refactor: getCurrentDate l…
ac45bfd 
…ogic
@lzeiml
refactor: class property order
d342eab
@lzeiml
refactor: function order
381f8c0
@lzeiml
feat: disable year outside min/max-date (first draft)
94dc13c
@lzeiml
feat: disable years based on min/max-date
d3bd416
@lzeiml
fix: isWithinMinMaxYear
aad19fe
@lzeiml
fix: infinite-scroll
885fc52
@lzeiml
feat: disable months based on min/max-date
f9c5054
@lzeiml
refactor: remove default values
29b0b2a
@lzeiml
fix: correctly display the calendar when weekStartIndex is set
88424e9
@lzeiml
fix: incorrect display if last week-number is 1
864cf81
@lzeiml
refactor: remove dayjs from workspace root
3851913
@lzeiml
Merge branch 'main' into date-picker-refactor
22aff48
@lzeiml
fix: merge
f97e1f2
@danielleroux danielleroux mentioned this pull request Sep 5, 2023
Closed
2 tasks
@danielleroux danielleroux changed the title Date picker refactor feat(core/datepicker): rework Sep 5, 2023
@lzeiml lzeiml requested a review from danielleroux October 25, 2023 07:42
@danielleroux danielleroux self-assigned this Oct 25, 2023
danielleroux
danielleroux previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

nuke-ellington
nuke-ellington requested changes Nov 2, 2023
View reviewed changes
packages/core/src/components/time-picker-rework/time-picker-rework.tsx Outdated Show resolved Hide resolved
packages/core/src/index.html Outdated Show resolved Hide resolved
....e2e.ts-snapshots/date-picker-year-month-selection-1-chromium---theme-classic-dark-linux.png Outdated Show resolved Hide resolved
packages/core/src/components/time-picker-rework/time-picker-rework.tsx Show resolved Hide resolved
...ker/date-picker.e2e.ts-snapshots/date-picker-basic-1-chromium---theme-classic-dark-linux.png Outdated Show resolved Hide resolved
...e2e.ts-snapshots/date-picker-year-month-selection-1-chromium---theme-classic-light-linux.png Outdated Show resolved Hide resolved
...e-picker-rework.e2e.ts-snapshots/date-picker-basic-1-chromium---theme-classic-dark-linux.png Outdated Show resolved Hide resolved
nuke-ellington
nuke-ellington requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - two more points:

  • Dropdown items and days still have the native white focus border
  • Navigation between days via arrow keys is missing

@lzeiml
Copy link
Contributor Author

lzeiml commented Nov 6, 2023

  • Dropdown items and days still have the native white focus border
    a85f19b
  • Navigation between days via arrow keys is missing
    7f45d25

@lzeiml lzeiml requested a review from nuke-ellington November 6, 2023 14:15
nuke-ellington
nuke-ellington requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features look good. Tests need to be fixed :)

@lzeiml
Copy link
Contributor Author

lzeiml commented Nov 8, 2023

Features look good. Tests need to be fixed :)

d10705e

@nuke-ellington nuke-ellington merged commit 9879b2c into main Nov 13, 2023
@nuke-ellington nuke-ellington mentioned this pull request Nov 16, 2023
Closed
nuke-ellington pushed a commit that referenced this pull request Nov 20, 2023
@lzeiml @danielleroux
@matthiashader @nuke-ellington
feat(core/date-picker/time-picker/date-time-picker): refactor (#737)
45ad343 
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: matthiashader <144090716+matthiashader@users.noreply.github.com>
@danielleroux danielleroux deleted the date-picker-refactor branch September 5, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiashader matthiashader matthiashader left review comments

@nuke-ellington nuke-ellington nuke-ellington approved these changes

@danielleroux danielleroux danielleroux left review comments

Assignees

@nuke-ellington nuke-ellington

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lzeiml @danielleroux @nuke-ellington @matthiashader