Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Primary Outline Angular Example uses Ghost Example instead #799

Closed
sn0wcat opened this issue Oct 3, 2023 · 0 comments · Fixed by #885
Closed

The Primary Outline Angular Example uses Ghost Example instead #799

sn0wcat opened this issue Oct 3, 2023 · 0 comments · Fixed by #885
Assignees
Labels
Documentation Improvements or additions to documentation

Comments

@sn0wcat
Copy link
Member

sn0wcat commented Oct 3, 2023

What happened?

In https://ix.siemens.io/docs/controls/button documentation page the primary button outline example for Angular uses the ghost button example:

image

It should probably look like this outline instead of ghost

import { Component } from '@angular/core';

@Component({
  selector: 'app-example',
  template: buttonSecondary(),
})
export default class Buttons {}
function buttonSecondary(): string | undefined {
  return `
      <ix-button class="m-1" outline variant="primary">
        Button
      </ix-button>
      <ix-button class="m-1" disabled outline variant="primary">
        Button
      </ix-button>
  `;
}

See also: https://community.siemens.com/t/ix-button-docs-not-accurate/451/2

@sn0wcat sn0wcat added Documentation Improvements or additions to documentation triage We discuss this topic in our internal weekly labels Oct 3, 2023
@matthiashader matthiashader removed the triage We discuss this topic in our internal weekly label Oct 31, 2023
@matthiashader matthiashader self-assigned this Oct 31, 2023
@matthiashader matthiashader linked a pull request Oct 31, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants