-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which .NET Platform should be supported by UrdfImporter and RosBridgeClient? #21
Comments
To be able to use ROS# with unity and hololens, the project must be built in the Universal Windows Platform (UWP), but the websocket library on which Rosbridgeclient is built on is not supported in UWP. So for UWP platform a custom websocket library needs to be built. I would suggest keeping the communication protocol user defined in Rosbridgeclient so that users can choose which protocol to use without too much change in the source code. |
From what I read here UWP also supports .NET Core Framework. From .NET Framework 4.5 on, .NET has its own WebSocket Class such that no external dependency as |
Like suggested I'll give my two cents here, too. |
@jaguar243 have you made progress with an UWP version of RosBridgeClient? Can you advise here? |
I'll commit my changes as a separate branch in the coming few days. Basically, I had to rebuild the RosBridgeClient using my custom websocket plugin that was compatible with UWP. No changes are needed on the ROS side. |
I found this pull request on the websocket-sharp github repository stating that it provides a websocket-sharp version supporting .NET Core. Anyone interested in UWP support of ROS# interested in trying it out and report the results here? Any suggestion on other websocket implementations to use instead of websocket-sharp? See also here sta/websocket-sharp#270 |
That pull request is super old and I couldn't get it working. However, I did learn today that Unity 2018.1 supports .NET 4.7 and assemblies compiled in .NET Standard 2.0. So .NET Standard 2.0 would work for both RosBridgeClient and UrdfImporter, and take care of the websocket-sharp incompatibility issue. |
Thanks for sharing this info @dwhit . We've been following Unity's .NET platform support and waited for such a release supporting .NET 4.5+. It has been announced for such a long time already. You are absolutely right: We can now also upgrade to .NET 4.7 and replace websocket-sharp by the .NET WebSocket class mentioned above. Let us continue the discussion on this topic in #59. |
Hi @MartinBischoff , |
We developed ROS# primarily for communicating with ROS from within Unity3D.
Official Unity3D Versions still support .NET Framework 3.5 only.
For Non-Unity3D-Applications of ROS#, UrdfImporter and RosBridgeClient could be provided in a more recent, "standardized" .NET platform.
Currently discussed versions are:
See https://docs.microsoft.com/en-us/dotnet/standard/ for an overview on .NET platforms.
Please use this issue to let us know the platforms you requrire for your project.
Please support us by providing suggestions how to manage multiple Platform releases in one Visual Studio Project as upgrading from .NET Framework 3.5 would complicate the applicabilty in Unity3D.
@blommers
The text was updated successfully, but these errors were encountered: