Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alertmanager.installDefaultRules name may be confusing #315

Open
ralgozino opened this issue Nov 22, 2024 · 0 comments
Open

alertmanager.installDefaultRules name may be confusing #315

ralgozino opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ralgozino
Copy link
Member

ralgozino commented Nov 22, 2024

In #159 we introduced the field .spec.distribution.modules.monitoring.alertmanager.installDefaultRules.

The installDefaultRules name of this field can be confusing to the user because, even when the field is false, Prometheus Rules are installed in the cluster, triggering alerts.

What this field disables is KFD default Alertmanager configuration for sending notifications for the aforementioned alerts.

Setting this field to true, let's the user create a custom Alertmanager configuration for routing the alerts.

I suggest renaming the field to something like installDefaultConfig instead.


Another improvement regarding to this field is setting in the schema the related fields deadManSwitchWebhookUrl, and slackWebhookUrl mandatory when installDefaultRules is true.

@ralgozino ralgozino added enhancement New feature or request size/S ~1d | Epic:~10d and removed size/S ~1d | Epic:~10d labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant