Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustyline or reedline for input? #104

Open
light4 opened this issue Nov 7, 2022 · 1 comment
Open

Use rustyline or reedline for input? #104

light4 opened this issue Nov 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@light4
Copy link
Contributor

light4 commented Nov 7, 2022

https://crates.io/crates/rustyline
https://crates.io/crates/reedline
@sigmaSd
Copy link
Owner

sigmaSd commented Nov 7, 2022

I think realistically using one of those 2 is the correct move, it will get rid of like 40% of the code and all the awkwardness in the code-base.

It was fun writing stuff from scratch but I think using a readline crate would make irust better

rustyline is solid but its maintained by a single person, reedline probably is what we want and it uses crossterm internally

The problem is reedline compared to rustyline has this limitation crossterm-rs/crossterm#396 but there is a pr filed for this , so I think its fine

@sigmaSd sigmaSd added the enhancement New feature or request label Nov 7, 2022
@sigmaSd sigmaSd mentioned this issue Apr 19, 2023
Closed
@sigmaSd sigmaSd mentioned this issue Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@light4 @sigmaSd