You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's bothered me ever since the beginning that if you want to set or get some key within sigmf you needed to do sigmf.SigMFFile.VERSION_KEY instead of just doing sigmf.VERSION_KEY. Now we appear to also have keys within archive.py for file extensions, which is strange.
Other modules (logging, pygame, numpy) have global vars like this in the top level.
I would like to:
Consolidate all keys into keys.py or similar name.
In the __init__.py do from .keys import * so that we can access a key using sigmf.VERSION_KEY.
In SigMFFile attach keys as properties for now and insert a comment saying that functionality will be deprecated in a future version. This keeps backwards compatibility.
This change should increment the minor version (major.minor.patch).
The text was updated successfully, but these errors were encountered:
It's bothered me ever since the beginning that if you want to set or get some key within
sigmf
you needed to dosigmf.SigMFFile.VERSION_KEY
instead of just doingsigmf.VERSION_KEY
. Now we appear to also have keys withinarchive.py
for file extensions, which is strange.Other modules (
logging
,pygame
,numpy
) have global vars like this in the top level.I would like to:
keys.py
or similar name.__init__.py
dofrom .keys import *
so that we can access a key usingsigmf.VERSION_KEY
.SigMFFile
attach keys as properties for now and insert a comment saying that functionality will be deprecated in a future version. This keeps backwards compatibility.This change should increment the minor version (
major.minor.patch
).The text was updated successfully, but these errors were encountered: