Skip to content

Commit 0b31522

Browse files
Quiet excessive warnings.
1 parent 2b94489 commit 0b31522

File tree

10 files changed

+53
-13
lines changed

10 files changed

+53
-13
lines changed

app/build.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ android {
9191
kotlinOptions {
9292
jvmTarget = signalKotlinJvmTarget
9393
freeCompilerArgs = listOf("-Xjvm-default=all")
94+
suppressWarnings = true
9495
}
9596

9697
keystores["debug"]?.let { properties ->
@@ -413,6 +414,8 @@ android {
413414
abortOnError = true
414415
baseline = file("lint-baseline.xml")
415416
checkReleaseBuilds = false
417+
ignoreWarnings = true
418+
quiet = true
416419
disable += "LintError"
417420
}
418421

app/src/main/java/org/thoughtcrime/securesms/mediasend/v2/MediaSelectionActivity.kt

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package org.thoughtcrime.securesms.mediasend.v2
33
import android.animation.ValueAnimator
44
import android.content.Context
55
import android.content.Intent
6-
import android.content.pm.ActivityInfo
76
import android.graphics.Color
87
import android.os.Bundle
98
import android.view.KeyEvent
@@ -17,15 +16,17 @@ import androidx.constraintlayout.widget.ConstraintSet
1716
import androidx.core.content.ContextCompat
1817
import androidx.core.view.updateLayoutParams
1918
import androidx.lifecycle.ViewModelProvider
20-
import androidx.navigation.Navigation
19+
import androidx.navigation.findNavController
2120
import androidx.navigation.fragment.NavHostFragment
2221
import androidx.transition.AutoTransition
2322
import androidx.transition.TransitionManager
2423
import com.google.android.material.animation.ArgbEvaluatorCompat
2524
import org.signal.core.util.BreakIteratorCompat
25+
import org.signal.core.util.OVERRIDE_TRANSITION_CLOSE_COMPAT
2626
import org.signal.core.util.getParcelableArrayListExtraCompat
2727
import org.signal.core.util.getParcelableExtraCompat
2828
import org.signal.core.util.logging.Log
29+
import org.signal.core.util.overrideActivityTransitionCompat
2930
import org.thoughtcrime.securesms.PassphraseRequiredActivity
3031
import org.thoughtcrime.securesms.R
3132
import org.thoughtcrime.securesms.components.emoji.EmojiEventListener
@@ -91,10 +92,6 @@ class MediaSelectionActivity :
9192
override fun onCreate(savedInstanceState: Bundle?, ready: Boolean) {
9293
setContentView(R.layout.media_selection_activity)
9394

94-
if (false) {
95-
requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
96-
}
97-
9895
FullscreenHelper.showSystemUI(window)
9996
WindowUtil.setNavigationBarColor(this, 0x01000000)
10097
WindowUtil.setStatusBarColor(window, Color.TRANSPARENT)
@@ -252,15 +249,15 @@ class MediaSelectionActivity :
252249
)
253250

254251
finish()
255-
overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
252+
overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
256253
}
257254

258255
override fun onSentWithoutResult() {
259256
val intent = Intent()
260257
setResult(RESULT_OK, intent)
261258

262259
finish()
263-
overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
260+
overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
264261
}
265262

266263
override fun onSendError(error: Throwable) {
@@ -276,7 +273,7 @@ class MediaSelectionActivity :
276273
Log.w(TAG, "Failed to send message.", error)
277274

278275
finish()
279-
overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
276+
overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
280277
}
281278
}
282279

@@ -285,7 +282,7 @@ class MediaSelectionActivity :
285282

286283
setResult(RESULT_CANCELED)
287284
finish()
288-
overridePendingTransition(R.anim.stationary, R.anim.camera_slide_to_bottom)
285+
overrideActivityTransitionCompat(OVERRIDE_TRANSITION_CLOSE_COMPAT, R.anim.stationary, R.anim.camera_slide_to_bottom)
289286
}
290287

291288
override fun onPopFromReview() {
@@ -336,7 +333,7 @@ class MediaSelectionActivity :
336333

337334
private inner class OnBackPressed : OnBackPressedCallback(true) {
338335
override fun handleOnBackPressed() {
339-
val navController = Navigation.findNavController(this@MediaSelectionActivity, R.id.fragment_container)
336+
val navController = this@MediaSelectionActivity.findNavController(R.id.fragment_container)
340337

341338
if (shareToTextStory && navController.currentDestination?.id == R.id.textStoryPostCreationFragment) {
342339
finish()

app/src/main/java/org/thoughtcrime/securesms/profiles/manage/EditProfileFragment.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("DEPRECATION")
2+
13
package org.thoughtcrime.securesms.profiles.manage
24

35
import android.content.DialogInterface
@@ -20,6 +22,7 @@ import com.bumptech.glide.Glide
2022
import com.google.android.material.dialog.MaterialAlertDialogBuilder
2123
import com.google.android.material.snackbar.Snackbar
2224
import org.signal.core.util.concurrent.LifecycleDisposable
25+
import org.signal.core.util.getParcelableCompat
2326
import org.thoughtcrime.securesms.AvatarPreviewActivity
2427
import org.thoughtcrime.securesms.LoggingFragment
2528
import org.thoughtcrime.securesms.R
@@ -57,7 +60,9 @@ class EditProfileFragment : LoggingFragment() {
5760
private lateinit var binding: EditProfileFragmentBinding
5861
private lateinit var disposables: LifecycleDisposable
5962

60-
private val DISABLED_ALPHA = 0.4f
63+
companion object {
64+
private const val DISABLED_ALPHA = 0.4f
65+
}
6166

6267
override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
6368
binding = EditProfileFragmentBinding.inflate(inflater, container, false)
@@ -128,7 +133,7 @@ class EditProfileFragment : LoggingFragment() {
128133
} else if (bundle.getBoolean(AvatarPickerFragment.SELECT_AVATAR_CLEAR)) {
129134
viewModel.onAvatarSelected(requireContext(), null)
130135
} else {
131-
val result = bundle.getParcelable<Media>(AvatarPickerFragment.SELECT_AVATAR_MEDIA)
136+
val result = bundle.getParcelableCompat(AvatarPickerFragment.SELECT_AVATAR_MEDIA, Media::class.java)
132137
viewModel.onAvatarSelected(requireContext(), result)
133138
}
134139
}

app/src/main/java/org/thoughtcrime/securesms/registration/viewmodel/SvrAuthCredentialSet.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package org.thoughtcrime.securesms.registration.viewmodel
77

88
import android.os.Parcelable
9+
import kotlinx.parcelize.IgnoredOnParcel
910
import kotlinx.parcelize.Parcelize
1011
import org.whispersystems.signalservice.api.svr.Svr3Credentials
1112
import org.whispersystems.signalservice.internal.push.AuthCredentials
@@ -23,7 +24,10 @@ data class SvrAuthCredentialSet(
2324
ParcelableSvr3AuthCredentials.createOrNull(svr3Credentials)
2425
)
2526

27+
@IgnoredOnParcel
2628
val svr2: AuthCredentials? = svr2Credentials?.credentials()
29+
30+
@IgnoredOnParcel
2731
val svr3: Svr3Credentials? = svr3Credentials?.credentials()
2832

2933
@Parcelize

app/src/main/java/org/thoughtcrime/securesms/service/webrtc/AndroidTelecomUtil.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ object AndroidTelecomUtil {
161161
return true
162162
}
163163

164+
@Suppress("DEPRECATION")
164165
fun selectAudioDevice(recipientId: RecipientId, device: SignalAudioManager.AudioDevice) {
165166
if (telecomSupported) {
166167
val connection: AndroidCallConnection? = connections[recipientId]
@@ -176,6 +177,7 @@ object AndroidTelecomUtil {
176177
}
177178
}
178179

180+
@Suppress("DEPRECATION")
179181
fun getSelectedAudioDevice(recipientId: RecipientId): SignalAudioManager.AudioDevice {
180182
if (telecomSupported) {
181183
val connection: AndroidCallConnection? = connections[recipientId]
@@ -199,6 +201,7 @@ object AndroidTelecomUtil {
199201
}
200202
}
201203

204+
@Suppress("DEPRECATION")
202205
@RequiresApi(26)
203206
private fun Connection.setAudioRouteIfDifferent(newRoute: Int) {
204207
if (callAudioState.route != newRoute) {

build-logic/plugins/build.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ kotlin {
1818
jvmToolchain {
1919
languageVersion.set(JavaLanguageVersion.of(signalKotlinJvmTarget))
2020
}
21+
compilerOptions {
22+
suppressWarnings = true
23+
}
2124
}
2225

2326
dependencies {

build-logic/plugins/src/main/java/signal-library.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ android {
3939

4040
kotlinOptions {
4141
jvmTarget = signalKotlinJvmTarget
42+
suppressWarnings = true
4243
}
4344

4445
lint {

build-logic/plugins/src/main/java/signal-sample-app.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ android {
4545

4646
kotlinOptions {
4747
jvmTarget = signalKotlinJvmTarget
48+
suppressWarnings = true
4849
}
4950

5051
buildFeatures {
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
/*
2+
* Copyright 2025 Signal Messenger, LLC
3+
* SPDX-License-Identifier: AGPL-3.0-only
4+
*/
5+
6+
package org.signal.core.util
7+
8+
import android.app.Activity
9+
import android.os.Build
10+
import androidx.annotation.AnimRes
11+
12+
val Activity.OVERRIDE_TRANSITION_OPEN_COMPAT: Int get() = 0
13+
val Activity.OVERRIDE_TRANSITION_CLOSE_COMPAT: Int get() = 1
14+
15+
fun Activity.overrideActivityTransitionCompat(overrideType: Int, @AnimRes enterAnim: Int, @AnimRes exitAnim: Int) {
16+
if (Build.VERSION.SDK_INT >= 34) {
17+
overrideActivityTransition(overrideType, enterAnim, exitAnim)
18+
} else {
19+
@Suppress("DEPRECATION")
20+
overridePendingTransition(enterAnim, exitAnim)
21+
}
22+
}

libsignal-service/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ tasks.withType<KotlinCompile>().configureEach {
3636
compilerOptions {
3737
jvmTarget = JvmTarget.fromTarget(signalKotlinJvmTarget)
3838
freeCompilerArgs = listOf("-Xjvm-default=all")
39+
suppressWarnings = true
3940
}
4041
}
4142
}

0 commit comments

Comments
 (0)