Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Group Screen Inconsistent UI States #13859

Open
3 tasks done
Sagar0-0 opened this issue Dec 29, 2024 · 1 comment
Open
3 tasks done

New Group Screen Inconsistent UI States #13859

Sagar0-0 opened this issue Dec 29, 2024 · 1 comment

Comments

@Sagar0-0
Copy link

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Steps to reproduce:

  1. Go to "Creating a new Group screen"(Go to New Message Screen,m Click on New Group Option)
  2. Initially, when no member is selected we will see the Skip button and Topbar containing the "Select Member" Text. When choosing one or more contacts, the topbar should show "X Members" and the Skip button will be a Chevron Icon.
  3. When you select and unselect members multiple times. The UI State starts to behave weirdly.

Actual behaviour:
For 1 selected member, it can show"Select Members", and for 0 members selected, it can show "0 members" and a chevron icon.
Expected behavior:
When no member is selected we should always see the "Skip" button and Topbar containing the "Select Member" Text. When choosing one or more contacts, the topbar should show "X Members" and the Skip button will be a Chevron Icon.

This issue is related to #13857 as Both of these activities are using the same ContactSelectionListFragment, fixing that issue can probably solve this issue too.

I am working on finding the cause, please assign both of these to me. I will come up with a PR ASAP.

Screenshots

document_6307481506528892853.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA

@Sagar0-0
Copy link
Author

I have solved this and #13857, there is one change in ContactSelectionListFragment fixing both issues. I am ready with a PR, please assign this to me and approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant