Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribed users are not removed from groups #6806

Closed
paride opened this issue Jul 12, 2017 · 6 comments
Closed

Unsubscribed users are not removed from groups #6806

paride opened this issue Jul 12, 2017 · 6 comments

Comments

@paride
Copy link

paride commented Jul 12, 2017

Steps to reproduce

  • Have a member of a group unsubscribe from Signal
  • Check how the now unsubscribed number is still part of the group
  • Now the stale number is impossible to remove from the group. Sometimes re-registering is not an option, as access to the number might have been lost. Most of the time the user just doesn't care.

Expected result: The unsubscribed user is automatically removed from all the groups. I know the server is not aware of groups, but I think there are still ways to handle this. For example:

  • When sending a message to a group (i.e., to all the group members), if a user is not a Signal user anymore, remove it;
  • Before adding a user to a group because of a message coming from another group member, check if the number is actually a Signal number.

Signal version: 4.8.0

@nrizzio
Copy link
Contributor

nrizzio commented Jul 12, 2017

This is unfortunately technically infeasible with the current group architecture and was rejected in #828.

@paride
Copy link
Author

paride commented Jul 12, 2017

@nrizzio How is my proposal incompatible with the current architecture? There's no need for a group administrator (what #828 is about).

@nrizzio
Copy link
Contributor

nrizzio commented Jul 12, 2017

My interpretation may very well be incorrect. In the interest of reducing notification spam, I'm going to take a step back and let Moxie make a determination when he gets around to it. Feel free to make a thread on the forum though.

@haffenloher
Copy link
Contributor

When sending a message to a group (i.e., to all the group members), if a user is not a Signal user anymore, remove it

That was the plan at some point (see #5891 (comment)), but Lilia and Moxie ended up deciding against it (see #6175).

@Trolldemorted
Copy link
Contributor

@paride you cannot just remove a member from a group on your device without things going terribly wrong.

So far no one has come up with a scheme for removing group members in asynchronous egalitarian groups that is simple and works.

I had suggested a single source of truth-device which "owns" the group and is the only device capable of sending group updates, but apparently moxie did not like it (and neither did i tbh since it imposes severe limitations to the user).

I am all in for some brainstorming to devise a new groups scheme, but this is not the right place (unlike the forum or the subreddit).

@moxie0 i know you do not want the groups "to be on the server", but would storing an encrypted blob (to which the server does not have the key) be ok? I don't think there is a way to solve signal's group issues without an external instance (read: not a signal device) deciding which async event came first.

@paride
Copy link
Author

paride commented Jul 12, 2017

Duplicate of #6175.

(Still, the issue remains to be addressed.)

@paride paride closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants