Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display QR code in "Verify Safety Number" #1223

Closed
1 task done
riyapenn opened this issue Jun 1, 2017 · 2 comments
Closed
1 task done

Display QR code in "Verify Safety Number" #1223

riyapenn opened this issue Jun 1, 2017 · 2 comments

Comments

@riyapenn
Copy link

riyapenn commented Jun 1, 2017

  • I have searched open and closed issues for duplicates

Bug description

Add display of QR code (for a separate phone to scan)

Steps to reproduce

  • Go to 1:1 chat
  • Menu/Conversation Setting
  • Verify Safety Number

Actual result: See the 60-digit number
Expected result: See a QR Code and 60-digit number

Screenshots

screen shot 2017-06-01 at 11 57 05 am

@liliakai
Copy link
Contributor

liliakai commented Jun 1, 2017

I think to do this we're going to need to migrate to a qr code library that accepts arbitrary buffers of data as input. Our current library only accepts strings, and javascript only supports UTF-16 strings, but the mobile clients are looking for a qr code that decodes to a Latin-1 encoded string.

The scannableFingerprint branch contains a WIP implementation which (last I checked) works except for this string encoding issue.

@jonathancross
Copy link

@liliakai Any updates on this?
Also where is the scannableFingerprint branch mentioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants