Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] [Feature] Direct Answer in Notifications #1541

Closed
1 task done
ghost opened this issue Oct 5, 2017 · 2 comments
Closed
1 task done

[Electron] [Feature] Direct Answer in Notifications #1541

ghost opened this issue Oct 5, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 5, 2017

  • I have searched open and closed issues for duplicates

Answer messages in Notifications

It would be great if Signal allows to answer Notifications like in Telegram.

Steps to reproduce

  • receive the message
  • get notification
  • can't answer in notification

Actual result: Click on Message opens Signal
Expected result: Signal allows direct answer in Notification

Screenshots

Actual result:

now

Expected result:

"Hovering" the notification
mockup_reply_message_hover
Click on reply:
mockup_reply_message_clicked
Send Message

Platform info

Operating System: macOS High Sierra 10.13

Signal version: Signal Electron v1.0.27

Pull Request

I don't know how this works on other operating systems, so how will this work on Linux and Windows?

Question to @scottnonnenberg and @liliakai: Is this feature on the roadmap and should someone build a pull request or not?

@liliakai
Copy link
Contributor

liliakai commented Oct 9, 2017

I believe this is only possible on mac, using either https://github.com/CharlieHess/node-mac-notifier from the renderer or https://electron.atom.io/docs/api/notification/ from the main process.

@FeuRenard
Copy link

FeuRenard commented Dec 9, 2017

This is in principle also possible with GNOME on Linux: https://help.gnome.org/users/gnome-help/stable/gs-respond-messages.html.en
Here it was asked to add the feature to Electron: electron/electron#7285
It seems to be difficult to find documentation on this: https://github.com/SolarLiner/libnotify-terminal/issues/17

EDIT: In the following PR there seems to be an example for inline reply API usage on Mac: electron/electron#9269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants