Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for per-line LTR/RTL determination in message contents #2562

Closed
Xashyar opened this issue Jul 23, 2018 · 10 comments
Closed

Comments

@Xashyar
Copy link
Contributor

Xashyar commented Jul 23, 2018

Have problems sending messages in languages such as Farsi, Arabic etc.

@scottnonnenberg-signal
Copy link
Contributor

Please detail the problems you're having. Screenshots and or video would really help.

@scottnonnenberg-signal
Copy link
Contributor

I can tell based on your screenshot that you're using a beta version, but that won't always be the case. Please follow the template next time, providing specifics of the issue, version number, etc.

@scottnonnenberg-signal
Copy link
Contributor

Also, this should be fixed in the latest beta release. Have you seen any improvements on this?

@Xashyar
Copy link
Contributor Author

Xashyar commented Jul 31, 2018

@scottnonnenberg-signal
it's still the same problem in 1.15.0.Beta-6

@scottnonnenberg-signal
Copy link
Contributor

@khashyarkh Has text ever flowed properly for you in previous versions of Signal Desktop?

@Xashyar
Copy link
Contributor Author

Xashyar commented Jul 31, 2018

@scottnonnenberg-signal yes it was Ok in the previous versions (before the new UI), in 1.14.0 and older.

@Xashyar
Copy link
Contributor Author

Xashyar commented Aug 21, 2018

@scottnonnenberg-signal
Hi, i know the issue was almost resolved thanks to @sha-265 but the problem still persists, if you insert numbers (which are Latin by default) or any Latin Letters within your message, it will falsely reorient the whole message.

Also:
by hitting "Left Ctrl + Shift" and "Right Ctrl + Shift" the whole text realigns accordingly, which is not a very desired behavior.

Thank u very much for your Great Work btw.

@sha-265
Copy link
Contributor

sha-265 commented Aug 21, 2018

@khashyarkh, the dir=auto property working simply by finding the first character with a strong directionality in the element, then applies that directionality to the whole element. Developing a better algorithm (maybe like wraping every non-LTR text with <bdi> tags) is much more complex than using dir=auto property on the containing element.

I'd recommend to start a message with RTL character if you want RTL orientation for your message, or LTR character if you want LTR orientation.

@Xashyar
Copy link
Contributor Author

Xashyar commented Aug 23, 2018

@sha-265
is it possible to check directionality on a per-new-line basis?
i know Telegram does this although after u send the messages.

image

@sha-265
Copy link
Contributor

sha-265 commented Aug 25, 2018

@khashyarkh, only if you add code that wrapping each line with html element with dir=auto property.

@scottnonnenberg-signal scottnonnenberg-signal changed the title Feature Request: Support for RTL Languages (Beta) Feature Request: Support for per-line LTR/RTL determination in message contents Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants
@sha-265 @Xashyar @scottnonnenberg-signal @automated-signal and others