Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauging For Interest: Copy to Clipboard IconButton next to Save Icon Button #4712

Closed
1 task done
ZackDeRose opened this issue Dec 15, 2020 · 6 comments
Closed
1 task done

Comments

@ZackDeRose
Copy link
Contributor

ZackDeRose commented Dec 15, 2020

  • I have searched open and closed issues for duplicates

Feature Description

Would extend off of: #4643 / #4614 / #307

Would add Icon button next to the save button for better discoverability of the capability:

Placed between elipses(sp?) and save button in Timeline component:
copy to clipboard icon placement

Placed between close and save in Lightbox component:
Copy to Clipboard

Would need similar checks as the option to copy to clipboard from the context menu as to whether or not to show the button.

Questions

  • Would this be a welcome feature? Are there other alternatives you'd prefer implemented from a UX standpoint?
  • Not immediately apparent where the icon pack is sourced - could you point me to the right location or give a preferred icon to use?
  • For images not in a 'copyable' format, would be better to rm icon from the DOM? or disable with tooltip? (My preference would be to disable with tooltip to give some feedback as to why a feature is sometimes available and other times not)
@vacekj
Copy link

vacekj commented Dec 15, 2020

Big +1 from me, I often copy paste images from one app to another and having to first download an image from Signal is bad UX.
Another way of doing is to make the image right-clickable, with an option to copy and save as in the context menu. This would probably be easier to implement.

@ZackDeRose
Copy link
Contributor Author

ZackDeRose commented Dec 16, 2020

Thanks @vacekj! There has been a feature recently that did add copying to clipboard via the context menu (#4614) [I had originally linked the wrong issue, but just edited to fix].

From what I can tell though, the context menu is not used very often in the App, and now I believe is only active via a context menu open action on the Lightbox component (the second one pictured) - and not in the Timeline view (the first picture)

My thought was to add it as a button (while still keeping the current context menu implementation) to boost discoverability of the feature. Depending on the core team's UI preferences - adding more buttons may become problematic as the app grows, and I think adding a Copy Image to Clipboard command to the ellipses drop-down would be an equally valid implementation for this feature too!

@scottnonnenberg-signal scottnonnenberg-signal changed the title Gaging For Interest: Copy to Clipboard IconButton next to Save Icon Button Gauging For Interest: Copy to Clipboard IconButton next to Save Icon Button Dec 16, 2020
@EvanHahn-Signal
Copy link
Contributor

Thanks for reporting this. I'll ask our Design team about this in early 2021.

In the meantime, you can open the context menu in the image lightbox as @ZackDeRose describes.

@ZackDeRose
Copy link
Contributor Author

Thanks for the feedback @EvanHahn-Signal!! Looking forward to hearing thoughts from the design team.

Also, an off-topic request: would y'all considering creating a Help Wanted / Good First Issue label? Would love to help in ways that are useful to the team!

@EvanHahn-Signal
Copy link
Contributor

This is something we've thought about and will likely do! Glad to know it's something that's of interest to you, too.

@stale
Copy link

stale bot commented Sep 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants