Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shown length of voice messages is always inaccurate #7036

Open
2 tasks done
NetSysFire opened this issue Sep 28, 2024 · 0 comments
Open
2 tasks done

Shown length of voice messages is always inaccurate #7036

NetSysFire opened this issue Sep 28, 2024 · 0 comments

Comments

@NetSysFire
Copy link
Contributor

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

This is pretty much exactly #6908, except that this is a supported signal desktop build. The issue has been present since quite some time but I could never bothered to report this until now. This is a minor issue as the effect is purely cosmetic and does not actually affect how a voice message is played.

Steps to reproduce

  1. Receive any voice message from a user.
  2. Play the voice message.

Expected result

The timer and progress bar matches the length of the voice message exactly.

Actual result

The progress bar and timer reaches its end too soon. Any voice message is pretty much always a couple of seconds longer than the UI expects. I think this scales with length, the longer the voice message, the higher the inaccuracy.

With a 2 minutes and 18 seconds long voice message I got ~11 seconds of inaccuracy.

Voice message as displayed in signal desktop:
image

The very same voice message as displayed on my linked Android phone:
image

The sender of the voice message also uses Android.

Screenshots

No response

Signal version

7.26.0 production

Operating system

Arch Linux

Version of Signal on your phone

7.17.6 (Android)

Link to debug log

In app.log I see the following events spammed after the voice message exceeds the expected length:

{"level":30,"time":"2024-09-28T14:59:41.497Z","msg":"NotificationService not updating notifications. Notifications are enabled; app is focused; there is no notification data"}
{"level":30,"time":"2024-09-28T14:59:42.473Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.494Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.534Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.554Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.575Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.595Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.615Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.636Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.656Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.696Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.716Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.737Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.757Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.778Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.798Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.818Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.859Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.879Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.899Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.920Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.940Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.961Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:42.980Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.021Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.042Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.062Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.083Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.103Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.124Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.143Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.184Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.205Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.224Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.244Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.265Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.286Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.306Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.347Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.367Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.387Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.408Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.428Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.448Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":30,"time":"2024-09-28T14:59:43.469Z","msg":"SmartVoiceNotesPlaybackProvider: `durationchange` event [REDACTED]2a0"}
{"level":40,"time":"2024-09-28T14:59:43.469Z","msg":"ActionRateLogger: got 25 events since 1727535582940: audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/CURRENT_TIME_UPDATED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/CURRENT_TIME_UPDATED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED,audioPlayer/DURATION_CHANGED"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant