Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose combine_with option in multilineConfig section #756

Closed
matthewmodestino opened this issue Apr 26, 2023 · 3 comments · Fixed by #993
Closed

Expose combine_with option in multilineConfig section #756

matthewmodestino opened this issue Apr 26, 2023 · 3 comments · Fixed by #993
Labels
enhancement New feature or request Splunk Platform Issue related to Splunk Platform destination

Comments

@matthewmodestino
Copy link

Is your feature request related to a problem? Please describe.

When using multilineConfig in the helm chart, it defaults to using the filelog operator default option for combinie_with which is \n

This can cause extra whitespace/lines to be rendered in the Splunk back end, where what I actually want for some recombined logs is to set combine_with to ""

image

Describe the solution you'd like

Expose the option for combine_with in the multiline_config section.

Describe alternatives you've considered

To workaround this, I would have to grab the rendered router and recombine operators from the config map and move them to the extraOperators section in the helm chart instead.

Additional context

We had a similar experience in Splunk Connect for Kubernetes, and eventually exposed more of the concat plugin features to control these things in the helm chart as well.

https://github.com/splunk/splunk-connect-for-kubernetes/blob/a65f108f0e41b6ababf811be9217ae10f0f079ba/helm-chart/splunk-connect-for-kubernetes/values.yaml#L266

@matthewmodestino matthewmodestino added the enhancement New feature or request label Apr 26, 2023
@matthewmodestino
Copy link
Author

matthewmodestino commented Aug 29, 2023

bump...

Ran into another situation where exposing more recombine operator options would have helped.

This time, max_batch_size of the filelog operator would have been much easier exposed as a part of the multilineConfig section, kinda like we did with the max_log_size.

Workaround again was to configure multilineConfig, take the config generated in configmap, then move it all to extraOperators section with the settings we wanted to set.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. If this issue is still relevant, please leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Oct 30, 2023
@matthewmodestino
Copy link
Author

Still want this..

@atoulme atoulme added Splunk Platform Issue related to Splunk Platform destination and removed Stale labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Splunk Platform Issue related to Splunk Platform destination
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants