DNM: Test the test from fix choco upgrade with custom env vars #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, the double-quote issue is making the upgrade test not to finish because the MSI tries to display a dialog box and there is no one to click on it... let me modify the code to test the env vars themselves |
Co-authored-by: Jeff Cheng <83052155+jeffreyc-splunk@users.noreply.github.com>
|
Equivalent to the test above but with the correct test code https://github.com/signalfx/splunk-otel-collector/actions/runs/10947292400/job/30396219992#step:5:189 |
|
ok, tests are working as intended |
pjanotti
deleted the
test-test-fix-choco-upgrade-with-custom-env-vars
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be double-safe and test the test for this, related PR #5386