-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring JaegerThrift exporter and factory into this repo #85
Comments
We didn't get ahead of it. :). Anyway, here's the PR that removed it: open-telemetry/opentelemetry-java-instrumentation#2073 |
Hmm, isn't it already here? https://github.com/signalfx/splunk-otel-java/blob/main/custom/src/main/java/com/splunk/opentelemetry/jaeger/JaegerThriftSpanExporterFactory.java It was added to this repo before otel-java-instr had it |
Ok, the factory is here but the |
|
Aha! Then I think we are good. Thanks y'all. |
For good reason, the upstream agent is looking to remove the
JaegerThriftSpanExporter
(and supporting factory/builders). Splunk should probably get ahead of this upstream issue:open-telemetry/opentelemetry-java-instrumentation#1973
and copy the classes into this repo so that they can be removed there.
The text was updated successfully, but these errors were encountered: