Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring JaegerThrift exporter and factory into this repo #85

Closed
breedx-splk opened this issue Jan 15, 2021 · 5 comments
Closed

Bring JaegerThrift exporter and factory into this repo #85

breedx-splk opened this issue Jan 15, 2021 · 5 comments

Comments

@breedx-splk
Copy link
Contributor

For good reason, the upstream agent is looking to remove the JaegerThriftSpanExporter (and supporting factory/builders). Splunk should probably get ahead of this upstream issue:
open-telemetry/opentelemetry-java-instrumentation#1973
and copy the classes into this repo so that they can be removed there.

@breedx-splk
Copy link
Contributor Author

We didn't get ahead of it. :). Anyway, here's the PR that removed it: open-telemetry/opentelemetry-java-instrumentation#2073

@mateuszrzeszutek
Copy link
Contributor

@breedx-splk
Copy link
Contributor Author

Ok, the factory is here but the JaegerThriftSpanExporter is not (yet). The factory imports it from upstream (I think).

@jkwatson
Copy link
Contributor

@breedx-splk
Copy link
Contributor Author

Aha! Then I think we are good. Thanks y'all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants