Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade @opentelemetry/intstrumentation #595

Closed
flex-jonghyen opened this issue Nov 1, 2022 · 4 comments
Closed

Need to upgrade @opentelemetry/intstrumentation #595

flex-jonghyen opened this issue Nov 1, 2022 · 4 comments

Comments

@flex-jonghyen
Copy link

flex-jonghyen commented Nov 1, 2022

"@opentelemetry/instrumentation" has some problem from "require-in-the-middle" that is hooking "require".
It is fixed in this pr. but is not deployed.
It makes so many performance problem.

And @opentelemetry/instrumentation version is greater than @splunk/otel's dependency version (^0.33.0).
I want to use fixed @opentelemetry/instrumentation with @splunk/otel.

Because I want to solve this problem, If you let me know how to know that the package upgrade.
Thanks.

@seemk
Copy link
Contributor

seemk commented Nov 1, 2022

Hi, which version of the distro are you using? We just released 2.0, which is using the latest instrumentation packages.

As for the fix for require in the middle, this will be brought in when it's published

@flex-jonghyen
Copy link
Author

flex-jonghyen commented Nov 1, 2022

@seemk I checked 2.0 rc.
But, It describe instrumentation package 0.33.0.
Does will it change?

@flex-jonghyen flex-jonghyen changed the title Need @opentelemetry/intstrumentation Need to upgrade @opentelemetry/intstrumentation Nov 1, 2022
@seemk
Copy link
Contributor

seemk commented Nov 22, 2022

Updated @opentelemetry/instrumentation to 0.34.0. Release coming soon.

@seemk seemk closed this as completed Nov 22, 2022
@flex-jonghyen
Copy link
Author

Good news! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants