Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Preview Alias Transfer Transaction #140

Open
ipr0310 opened this issue Mar 8, 2023 · 5 comments
Open

Enhancement: Preview Alias Transfer Transaction #140

ipr0310 opened this issue Mar 8, 2023 · 5 comments

Comments

@ipr0310
Copy link
Member

ipr0310 commented Mar 8, 2023

As the title says when transferring an alias the transaction preview has a little typo, it is mis-labeled

Additional context
Technically, an alias on private sale with 0 as price immediately transfers the alias to the receiver.

Expected behavior
When the explorer detects an alias private sell with the price of 0, it should be labeled as Alias Transfer

@ipr0310
Copy link
Member Author

ipr0310 commented Mar 8, 2023

@pir8radio
Copy link
Collaborator

we just grab whats in the node database. how is it stored on chain? as a SELL or Transfer?

@ipr0310
Copy link
Member Author

ipr0310 commented Apr 6, 2024

SELL with price of 0

Selling something for 0 SIGNA

@pir8radio
Copy link
Collaborator

wouldnt that still be a sale? If i sell you my car for .0000001 or just 0 we made a deal and i sold it. or other way around, if i sell you my car for $100 wouldnt that be a transfer of ownership.. should all sales be called transfers instead? since they all transfer to a new owner no matter the price 100000 or 0?

@ipr0310
Copy link
Member Author

ipr0310 commented Apr 14, 2024

That's how we do on SignumSwap for alias transfer, sell an alias for 0 SIGNA, and automatically the alias gets transferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants