Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pool admins to set the solo percentage threshold. Currently hard coded to 20% #69

Open
pir8radio opened this issue Apr 3, 2022 · 1 comment
Labels
Investigation Needs further investigation, e.g. is it reproducable, is it an error with the app or the network Protocol change Issues that are related to upcoming protocol changes and though require special priority

Comments

@pir8radio
Copy link

Allow pool admins to set the solo percentage threshold. Currently hard coded to 20%. a setting in the config file would be great. So we could set the solo mining threshold from 1-99%

@ipr0310 ipr0310 added Investigation Needs further investigation, e.g. is it reproducable, is it an error with the app or the network Protocol change Issues that are related to upcoming protocol changes and though require special priority labels Apr 3, 2022
@pir8radio
Copy link
Author

pir8radio commented Apr 14, 2022

Not really a protocol change more something like:

    // Take pool fee
    float feePercentage = propertyService.getFloat(Props.poolFeePercentage);
    if(winningMiner.getSharePercent() < propertyService.getInt(Props.poolSoloSharePercentage)) {
        // charge the solo fee
        feePercentage = propertyService.getFloat(Props.poolSoloFeePercentage);
    }

then add a config property "poolSoloSharePercentage = 30"
would also need to pull that value into the "Pool Info" react tab to show the change to the users.

I'm not a java pro.. lol so that probably wont work, but its in the ball park I suspect. I can figure it out and do a pull i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigation Needs further investigation, e.g. is it reproducable, is it an error with the app or the network Protocol change Issues that are related to upcoming protocol changes and though require special priority
Projects
None yet
Development

No branches or pull requests

2 participants