Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creationBytes as POST body #20

Open
ohager opened this issue Mar 8, 2022 · 1 comment
Open

creationBytes as POST body #20

ohager opened this issue Mar 8, 2022 · 1 comment
Labels
core Core Package enhancement New feature or request

Comments

@ohager
Copy link
Member

ohager commented Mar 8, 2022

Is your feature request related to a problem? Please describe.
Smart Contracts byte code is attached as URL parameter. URL length is limited (not even have the same limit on difference browsers) and complex contracts may not be publishable using SignumJS. The Signum Node supports to receive a contracts creation byte sequence as body.

Describe the solution you'd like
Mount the creation byte sequence and attach as body instead of sending as URL parameters

The creation byte sequence has to be mounted as depicted in SignumJ

https://github.com/signum-network/signumj/blob/45c0528df866b2f331606a6ca52771b8d2aea955/src/main/java/signumj/crypto/SignumCryptoImpl.java#L472

Describe alternatives you've considered
There's no alternative

@ohager ohager added enhancement New feature or request core Core Package labels Mar 8, 2022
@deleterium
Copy link
Contributor

Maybe I can help, tell me were to do. I already did a parse for creation bytes here

https://github.com/deleterium/smartc-signum-decompiler/blob/d041a52fa8989d0c132a741e9660deb98a0f1464/src/index.ts#L311

Works for at version 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core Package enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants