Collecting fee recipients from pre-merge validators

[paulhauner]

Description

After Bellatrix, it will eventually be necessary for Lighthouse to know one more detail for each validator: the suggested_fee_recipient (SFR) for producing an execution payload ("eth1 block").

For new validators, it makes sense to add a SFR to the lighthouse account validator commands that create a validator.

In #2924, the suggested_fee_recipient can be loaded from CLI, from file and from the validator_definitions.yml file. To me, it seems like the clearest strategy would be to get users to edit the validator_definitions.yml. Perhaps it would be nice if we wrote a lighthouse account tool that can be pointed at a validator_definitions.yml file and it will request a SFR for each validator and update the file.

[paulhauner]

Here is Teku's work along these lines: Consensys/teku#4894

[james-prysm]

Here is Prysm's implementation that follows something similar prysmaticlabs/prysm#10292

[michaelsproul]

Closing this as we now support the fee recipient HTTP API and fee recipients in the validator definitions YAML

[djbakerman]

for the SFR would that be an ETHv1 or ETHv2 address? Any reason why it should not be the same as the validator public address?

[michaelsproul]

@djbakerman We just added an FAQ on this exact point! You can give it a test drive here: https://lighthouse-book.sigmaprime.io/suggested-fee-recipient.html#why-do-i-have-to-nominate-an-ethereum-address-as-the-fee-recipient

Let us know if that helps or if you think there's anything you think we should add

[djbakerman]

Thank you that was helpful. Perhaps obvious, but it's worth mentioning something like: "If the execution node is testnet, ensure the ETHv1 address is a testnet address"