-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MAX_REQUEST_BLOCKS
runtime-configurable
#4811
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In Deneb, the
MAX_REQUEST_BLOCKS
became configurable. We are currently using type-level numbers and constants for this on bothstable
and Deneb:lighthouse/beacon_node/lighthouse_network/src/rpc/methods.rs
Lines 24 to 26 in 203ac65
lighthouse/beacon_node/lighthouse_network/src/rpc/methods.rs
Lines 32 to 33 in 203ac65
Ideally we would like to be able to configure this on a per-network basis, which would mean getting rid of the compile-time constants. This might be quite hard to do.
Steps to resolve
Easier option
max_request_blocks
andmax_request_blocks_deneb
to the chain spec and ensure that the runtime-configured values match the compile-time ones (fail with an invalid config error if not).Harder option
MAX_REQUEST_BLOCKS
. E.g. this one.The text was updated successfully, but these errors were encountered: