Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check availability cache when serving block by root requests #5093

Closed
realbigsean opened this issue Jan 19, 2024 · 1 comment
Closed

Check availability cache when serving block by root requests #5093

realbigsean opened this issue Jan 19, 2024 · 1 comment
Labels
deneb

Comments

@realbigsean
Copy link
Member

realbigsean commented Jan 19, 2024 •
edited
Loading

Description

We aren't quire compliant with this change from the previous pre-release (v1.4.0-beta.5) ethereum/consensus-specs#3551

We are serving blobs in accordance to the spec because we're accessing the data availability cache. With blocks, we're using the early attestation cache, which only holds one block at a time, the one we currently think will be head. Using the availability cache instead should get us fully compliant with this spec change.
@realbigsean realbigsean mentioned this issue Jan 19, 2024
Merged
@realbigsean realbigsean mentioned this issue Jan 29, 2024
Merged
@realbigsean
Copy link
Member Author

implemented in #5138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deneb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@realbigsean