Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild lcli only when it is updated #5861

Closed
realbigsean opened this issue May 29, 2024 · 2 comments
Closed

Rebuild lcli only when it is updated #5861

realbigsean opened this issue May 29, 2024 · 2 comments
Labels
infra-ci

Comments

@realbigsean
Copy link
Member

Description

We recently updated CI to rebuild lcli every run, which adds ~3 minutes. We should be able to cache it most of the time but any PR that updates lcli needs to have it rebuilt, otherwise CI might break.

Relevant PR: #5860

Issue and solution described here:
#5860 (comment)
@jimmygchen
Copy link
Member

lcli build is no longer required by doppelganger tests (#5865), so we may be able to close this?

@realbigsean
Copy link
Member Author

incredible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra-ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimmygchen @realbigsean