Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --http-token-path flag to the VC #6563

Open
michaelsproul opened this issue Nov 4, 2024 · 2 comments
Open

Add --http-token-path flag to the VC #6563

michaelsproul opened this issue Nov 4, 2024 · 2 comments
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs val-client Relates to the validator client binary

Comments

@michaelsproul
Copy link
Member

Description

We considered the issue of VC HTTP token provisioning solved with the closure of:

However, we didn't add a CLI flag to set the token path. This issue tracks the addition of this flag.

Present Behaviour

Lighthouse always reads and writes the token from the $datadir/validators/api-token.txt path.

Expected Behaviour

If the user supplies the --http-token-path to the VC then the token should be read/written from this path instead. The flag should require the --http flag to also have been provided.

@michaelsproul michaelsproul added good first issue Good for newcomers val-client Relates to the validator client binary low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs labels Nov 4, 2024
@syjn99
Copy link

syjn99 commented Nov 5, 2024

Hi, i'd like to take this one for my first contribution

@michaelsproul
Copy link
Member Author

Awesome, thanks!

After you've got the code change worked out, you can add a CLI test in lighthouse/tests/validator_client.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low-hanging-fruit Easy to resolve, get it before someone else does! UX-and-logs val-client Relates to the validator client binary
Projects
None yet
Development

No branches or pull requests

2 participants