Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockbud CI job doesn't ever fail #6637

Open
eserilev opened this issue Dec 1, 2024 · 0 comments
Open

Lockbud CI job doesn't ever fail #6637

eserilev opened this issue Dec 1, 2024 · 0 comments
Labels

Comments

@eserilev
Copy link
Collaborator

eserilev commented Dec 1, 2024

Description

The lockbud CI job checks for any deadlocks in the codebase. However, if a deadlock is found, the CI job doesn't actually fail. Instead it just prints out some text related to the deadlock and the CI job is marked as completed succesfully.

image

It'd be much more helpful if the lockbud CI job actually failed when catching a deadlock.

There are two ways to potentially resolve this

  1. Contribute to lockbud to resolve the issue described here.
  2. Parse lockbud output like they do in this repo https://github.com/os-checker/os-checker and manually fail the CI job if a deadlock is found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant