Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with first byte to extend timeout for early sampling requests #6929

Closed
Tracked by #4983
dapplion opened this issue Feb 6, 2025 · 1 comment
Closed
Tracked by #4983

Comments

@dapplion
Copy link
Collaborator

dapplion commented Feb 6, 2025

As proposed by Codex, we can reduce lag when sampling in the happy path by sending DataColumnsByRoot requests immediately as we see the block and having the sampling provider hold the request until it gets the sample.

This mechanism is already implemented in our end, both the eager sending, and the holding of requests. However, we are bound by the ReqResp timeout, which may be too short depending on how wide the sampling window is. We may artificially extend the deadline by sending the first byte of data.

@dapplion dapplion mentioned this issue Feb 6, 2025
52 tasks
@dapplion dapplion changed the title Respond with first byte to extend timeout for early sampling requests (TBD) Respond with first byte to extend timeout for early sampling requests Feb 6, 2025
@dapplion
Copy link
Collaborator Author

dapplion commented Feb 6, 2025

The TTFB mechanism (time to first byte) has been deprecated. So we no longer need to send the first byte, just hold the request and expect the requester timeout to be enough.

@dapplion dapplion closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant