Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing execution tests with latest geth version #6937

Open
jimmygchen opened this issue Feb 7, 2025 · 1 comment
Open

Fix failing execution tests with latest geth version #6937

jimmygchen opened this issue Feb 7, 2025 · 1 comment
Labels
infra-ci test improvement Improve tests v7.0.0 New release c. Q1 2025

Comments

@jimmygchen
Copy link
Member

We made a workaround to use geth v1.10.10 instead of master to get CI to pass for the time being:

#6936

Our tests need to be updated to work with latest geth, due to these breaking changes:

  • removal of personal namespace in v1.14.12: See #30704
  • removal of totalDifficulty field from RPC in v1.14.11. See #30386.
@michaelsproul
Copy link
Member

michaelsproul commented Feb 7, 2025

I think the removal of total difficulty was also causing some of our readiness loggers to error. From interop channel on ETH R&D:

{"msg":"Unable to check genesis execution payload","level":"ERRO","ts":"2025-02-03T17:07:31.659060494Z","service":"slot_notifier","error":"ExecutionLayerGetBlockByNumberFailed(EngineError(Api { error: Json(Error("missing field totalDifficulty", line: 0, column: 0)) }))"}

It's cosmetic, but would be nice to fix (only relevant for devnets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci test improvement Improve tests v7.0.0 New release c. Q1 2025
Projects
None yet
Development

No branches or pull requests

2 participants