Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublicKey::from_bytes runs extremely slowly #55

Open
ncitron opened this issue Jan 31, 2023 · 0 comments
Open

PublicKey::from_bytes runs extremely slowly #55

ncitron opened this issue Jan 31, 2023 · 0 comments

Comments

@ncitron
Copy link

ncitron commented Jan 31, 2023

In my testing, it takes ~6ms to deserialize a single public key with this method. This is suspiciously slow. I suspect something strange is going on here.

#46 alludes to some performance issues there, but his benchmarks are an order of magnitude faster than mine. I am running an M1 macbook so I don't suspect it is my machine.

Interestingly, using from_bytes_unchecked is faster at around 1ms, but still undershoots previous benchmarks significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant