Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub loader doesn't use wiener_win_len argument value #106

Closed
papahabla opened this issue Aug 31, 2021 · 1 comment · Fixed by #144
Closed

Hub loader doesn't use wiener_win_len argument value #106

papahabla opened this issue Aug 31, 2021 · 1 comment · Fixed by #144

Comments

@papahabla
Copy link

I'm not sure if this is intentional or not but the wiener_win_len argument is not used by the hub_loader in the following code.

    # otherwise we load the separator from torchhub
    else:
        hub_loader = getattr(openunmix, model_str_or_path)
        separator = hub_loader(
            targets=targets,
            device=device,
            pretrained=True,
            niter=niter,
            residual=residual,
            filterbank=filterbank,
        )

To Reproduce

Call the command line with default and different --wiener-win-len value such as 600 and the outputs will be identical.

@faroit
Copy link
Member

faroit commented Aug 31, 2021

@papahabla good catch. Are you able to provide a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants