Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi up fails on main #397

Closed
jku opened this issue Feb 7, 2024 · 5 comments
Closed

Pulumi up fails on main #397

jku opened this issue Feb 7, 2024 · 5 comments
Assignees

Comments

@jku
Copy link
Member

jku commented Feb 7, 2024

Currently "pulumi up" (github-sync-main-sigstore) fails consistently on main. See example:
https://github.com/sigstore/community/actions/runs/7703455029/job/20993867318

The failure is

422 Commit signoff is enforced by the organization and cannot be disabled []

  • it's currently unclear why this started to suddenly fail between d9bdb66 and a388f3f : the config does not actually try to set webCommitSignoffRequired anywhere...
  • Bob tried to fix this by explicitly setting all repositories webCommitSignoffRequired to true in5a77a4b : this did not help
@cpanato
Copy link
Member

cpanato commented Feb 7, 2024

I will take a look on that

@cpanato cpanato self-assigned this Feb 7, 2024
@jku
Copy link
Member Author

jku commented Feb 7, 2024

Maybe related integrations/terraform-provider-github#2077

I can't figure out the versions of software we run but terraform-provider-github 5.43 mentioned in that issue is part of pulumi-github 5.24 which was released Jan 5 -- this seems to be at least close to our failure timeline.

@jku
Copy link
Member Author

jku commented Feb 7, 2024

Based on github-sync commits the differences between last working and first failing runs is

  • Bump github.com/pulumi/pulumi-github/sdk/v5 from 5.24.0 to 5.25.0
  • Bump github.com/pulumi/pulumi/sdk/v3 from 3.100.0 to 3.101.1

This does not exactly match the linked issue but is likely related.

@cpanato
Copy link
Member

cpanato commented Feb 7, 2024

fixed.
We need to disable the org policy for commit signoff and apply that for the repos we want, as we already did looks like.
I've disable that setting now.
cc @bobcallaway

Screenshot 2024-02-07 at 09 40 41

and retrigger the pipeline https://github.com/sigstore/community/actions/runs/7703455029

@haydentherapper
Copy link
Contributor

Thanks yall for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants