Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize password prompt logic for key generation/import functionality #1078

Closed
venafi-iw opened this issue Nov 19, 2021 · 1 comment
Closed

Centralize password prompt logic for key generation/import functionality #1078

venafi-iw opened this issue Nov 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@venafi-iw
Copy link
Contributor

Description

Consolidate password prompt logic to provide better code reuse as highlighted in PR #1050 (importing keypair) and generating keypair cmd/cosign/cli/generate/generate_key_pair.go -> getPassFromTerm(...)

@asraa
@venafi-iw venafi-iw added the enhancement New feature or request label Nov 19, 2021
@asraa
Copy link
Contributor

asraa commented Nov 22, 2021

  • also fileExists reuse across key gen and import

@asraa asraa mentioned this issue Nov 22, 2021
Merged
@venafi-iw venafi-iw mentioned this issue Jan 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asraa @venafi-iw