-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcpkms:// parsing is broken in 1.4.x #1259
Comments
thank you for letting us know about the bug @woohgit, I noticed that we called the wrong method which cause searching key from the file 🙋🏻♂️ |
Ah, I think there is an error with the key you store in GCP KMS because code will try to retrieve the key from KMS if an error occurred then it will try to download it from the file, please see. |
but yeah, we can be more helpful by logging the error before searching it in disk |
@developer-guy Do you think that there is anything with the key? It's working with 1.3.x with all our keys, and 1.4.x is not working with any of the keys. I'll build a local copy from your PR and see what's the error. |
Nah it looks good. No error this time, probably my GSA permissions / ADC permissions. |
Symptom
When trying to use cosign with GCP KMS, the
--key gcpkms://
is not parsed properly and handled as a local file path.Affected versions:
v1.4.0
v1.4.1
Example run error below:
It works well with
v1.3.x
The text was updated successfully, but these errors were encountered: