Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosigned may improperly block multi-arch images #786

Closed
mattmoor opened this issue Sep 24, 2021 · 1 comment
Closed

cosigned may improperly block multi-arch images #786

mattmoor opened this issue Sep 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Member

Description

As I was thinking about #784, this was another (largely orthogonal) thought

tl;dr cosigned only verifies root-level signatures, which for multi-arch indices may not be where the signatures live!

As we deal with multi-arch images, the signatures may exist deeper in the tree than on the tagged entity itself, so unless we do recursive verification this is going to be limiting. We also don't necessarily know which arch/platform/os to resolve for the image (consider heterogeneous clusters).

I think the check we really want here is: "every leaf image or one of its containing indices satisfies the check we are performing."

Right now, all we check is "is it signed?", so this is simpler, but if/as this expands into the broader policy space, this will get complicated fast.

@mattmoor mattmoor added the bug Something isn't working label Sep 24, 2021
@haydentherapper
Copy link
Contributor

Closing as outdated, @mattmoor lemme know if this is still relevant.

@haydentherapper haydentherapper closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants