Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Release cosigned artifacts with cosign releases? #952

Closed
n3wscott opened this issue Oct 26, 2021 · 5 comments
Closed

RFC: Release cosigned artifacts with cosign releases? #952

n3wscott opened this issue Oct 26, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@n3wscott
Copy link
Contributor

Description

I would like to do the work on releasing the cosigned webhook config (with signed image) independent of the helm chart.

I would like to know if anyone has a good reason for all the configuration options inside the helm chart? We can also ship the helm chart alongside the resolved release manifests without issues, it just means we will have two paths to install the webhook.

@n3wscott n3wscott added the enhancement New feature or request label Oct 26, 2021
@hectorj2f
Copy link
Contributor

@n3wscott The initial reason was to keep some consistency with the rest of helm charts. However we can have other arguments. I would ask @sabre1041.

@n3wscott
Copy link
Contributor Author

@hectorj2f I am more asking for a non-helm option.

@jkjell
Copy link
Contributor

jkjell commented Oct 27, 2021

@n3wscott any opinions or thoughts on the non-Helm solution? Just plain k8s manifests or something else?

@n3wscott
Copy link
Contributor Author

@jkjell it should be not much harder than ko resolve and store that manifest as an artifact, attach it to the release. Then sign the image with cosign via ko publish.

Ko should produce the same images via the two commands. If signing lands anything in ko it will be one step.

We might want to think to do a friendly fork of ko in sigstore for kosign : ko+cosign.

@dlorenc
Copy link
Member

dlorenc commented Feb 21, 2022

I think @k4leung4 just did this one in #1414

@dlorenc dlorenc closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants